From: Sebastian Reichel <sre@kernel.org>
To: Nicolas Saenz Julienne <nicolas.saenz@prodys.net>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] power: supply: sbs-battery: use fixed device name
Date: Tue, 22 Nov 2016 17:17:19 +0100 [thread overview]
Message-ID: <20161122161719.mcrcgsc2ec6jqjv2@earth> (raw)
In-Reply-To: <271e2a75-4676-b9ac-296b-282effc73d47@prodys.net>
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
Hi,
On Tue, Nov 22, 2016 at 04:31:51PM +0100, Nicolas Saenz Julienne wrote:
> > NAK. This is not ok for systems using multiple sbs-batteries.
> > Also please read:
>
> sorry I wasn't aware of that feature, I'll have a look at the
> whole thing and rework the patch.
no problem. I also reviewed the driver. Please include that in your
rework.
P.S.: https://web.archive.org/web/20080722025748/http://www.zip.com.au/~akpm/linux/patches/stuff/top-posting.txt
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2016-11-22 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 18:04 [PATCH 0/2] power: supply: add sbs-charger driver Nicola Saenz Julienne
2016-11-21 18:04 ` [PATCH 1/2] power: supply: sbs-battery: use fixed device name Nicola Saenz Julienne
2016-11-22 15:23 ` Sebastian Reichel
2016-11-22 15:31 ` Nicolas Saenz Julienne
2016-11-22 16:17 ` Sebastian Reichel [this message]
2016-11-21 18:04 ` [PATCH 2/2] power: supply: add sbs-charger driver Nicola Saenz Julienne
2016-11-22 16:11 ` Sebastian Reichel
2016-11-23 1:06 ` Phil Reid
2016-11-23 1:17 ` Phil Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122161719.mcrcgsc2ec6jqjv2@earth \
--to=sre@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nicolas.saenz@prodys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox