From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Rafael Wysocki <rjw@sisk.pl>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
linux-pm@vger.kernel.org,
Srinivas Pandruvada <srinivas.pandruvada@intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: [patch 0/5] powercap/intel_rapl: Fixes, hotplug conversion and simplifcation
Date: Tue, 22 Nov 2016 21:15:56 -0000 [thread overview]
Message-ID: <20161122210518.079483154@linutronix.de> (raw)
The driver fails to:
- initialize packages which are not available at driver init time, though
the value of that initialization is completely unclear as nothing ever
uses these values. I fixed it up nevertheless and leave it to the
maintainers to decide whether it should completely go away.
- to propagate error codes in the hotplug online path, where a
registration fails and the package data is freed, but return code is 0.
The initialization/removal code of that driver is a maze of duplicated code
which is more or less the same as the cpu hotplug code. After switching
over the driver to the hotplug statemachine, the whole init/removal
machinery can be replaced by installing/removing the hotplug state.
The total damage is:
intel_rapl.c | 363 ++++++++++++++++-------------------------------------------
1 file changed, 104 insertions(+), 259 deletions(-)
and the binary size shrinks as well:
text data bss dec hex
7996 625 32 8653 21cd Before
7216 593 32 7841 1ea1 After
Thanks,
tglx
next reply other threads:[~2016-11-22 21:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 21:15 Thomas Gleixner [this message]
2016-11-22 21:15 ` [patch 1/5] powercap/intel_rapl: Add missing domain data update on hotplug Thomas Gleixner
2016-11-23 1:22 ` Jacob Pan
2016-11-22 21:15 ` [patch 2/5] powercap/intel_rapl: Propagate error code when registration fails Thomas Gleixner
2016-11-22 21:16 ` [patch 3/5] powercap/intel rapl: Convert to hotplug state machine Thomas Gleixner
2016-11-22 21:16 ` [patch 4/5] powercap/intel_rapl: Cleanup duplicated init code Thomas Gleixner
2016-11-22 21:16 ` [patch 5/5] powercap/intel_rapl: Track active CPUs internally Thomas Gleixner
2016-11-23 19:06 ` [patch 0/5] powercap/intel_rapl: Fixes, hotplug conversion and simplifcation Jacob Pan
2016-11-23 21:12 ` Rafael J. Wysocki
2016-11-24 8:33 ` Thomas Gleixner
2016-11-24 21:04 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122210518.079483154@linutronix.de \
--to=tglx@linutronix.de \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
--cc=srinivas.pandruvada@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).