Re: [PATCH] power: supply: bq27xxx_battery: Fix register map for BQ27510 and BQ27520

Andrew F. Davis
2016-11-28T17:13:23Z

On 11/23/2016 05:08 PM, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Nov 04, 2016 at 01:33:13PM -0500, Andrew F. Davis wrote:
>> The BQ27510 and BQ27520 use a slightly different register map than the
>> BQ27500, add a new type enum and add these gauges to it.
>>
>> Fixes: d74534c27775 ("power: bq27xxx_battery: Add support for additional bq27xxx family devices")
>> Based-on-patch-by: Kenneth R. Crudup <kenny@panix.com>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>> drivers/power/supply/bq27xxx_battery.c | 41 +++++++++++++++++++++++++++++-
>> drivers/power/supply/bq27xxx_battery_i2c.c | 4 +--
>> include/linux/power/bq27xxx_battery.h | 3 ++-
>> 3 files changed, 44 insertions(+), 4 deletions(-)
>
> Queued into for-next. I think pali's hint, that bq27xxx_battery_overtemp()
> should be implemented using a switch-case is valid to make the code more
> readable. Please provide this change as follow-up patch.
>

I think there may be better ways than even switch-case, perhaps we can
add additional info flags to the part's description tables, then just
branch on that for each accessor type.

Anyway, I'll see what I can to to clean this up when I get some bandwidth.

Thanks,
Andrew