From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only used in slow path Date: Thu, 24 Nov 2016 05:53:37 +0100 Message-ID: <20161124045337.GB18417@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar Cc: Rafael Wysocki , Ingo Molnar , Peter Zijlstra , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , Juri Lelli , Robin Randhawa , Steve Muckle List-Id: linux-pm@vger.kernel.org Firstly, please start changes to scheduler code with a verb. This title: Subject: Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only used in slow path is totally inadequate as it's a statement that says nothing about the _change_. What does the patch do? Does it add, remove, modify, fix or clean up? * Viresh Kumar wrote: > Execute the irq-work specific initialization/exit code only when the > fast path isn't available. Is this an optimization? A correctness fix? Thanks, Ingo