From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Date: Thu, 24 Nov 2016 10:40:34 +0530 Message-ID: <20161124051034.GE9376@vireshk-i7> References: <09f8fe694b4491bfd20272e8c7dc0f13f35eb34e.1479197311.git.viresh.kumar@linaro.org> <20161124045118.GA18417@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pg0-f49.google.com ([74.125.83.49]:34025 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbcKXFKs (ORCPT ); Thu, 24 Nov 2016 00:10:48 -0500 Received: by mail-pg0-f49.google.com with SMTP id x23so14171040pgx.1 for ; Wed, 23 Nov 2016 21:10:37 -0800 (PST) Content-Disposition: inline In-Reply-To: <20161124045118.GA18417@gmail.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Ingo Molnar Cc: Rafael Wysocki , Ingo Molnar , Peter Zijlstra , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , Juri Lelli , Robin Randhawa , Steve Muckle On 24-11-16, 05:51, Ingo Molnar wrote: > > * Viresh Kumar wrote: > > > + /* > > + * For Real Time and Deadline tasks, schedutil governor shoots the > > + * frequency to maximum. And special care must be taken to ensure that > > + * this kthread doesn't result in that. > > + * > > + * This is (mostly) guaranteed by the work_in_progress flag. The flag is > > + * updated only at the end of the sugov_work() and before that schedutil > > + * rejects all other frequency scaling requests. > > + * > > + * Though there is a very rare case where the RT thread yields right > > + * after the work_in_progress flag is cleared. The effects of that are > > + * neglected for now. > > + */ > > s/schedutil governor/ > the schedutil governor > > s/And special care must be taken/ > Special care must be taken > > s/at the end of the sugov_work()/ > at the end of the sugov_work() function > > s/before that schedutil rejects/ > before the schedutil governor rejects > > s/Though there is a very rare case where > There is a very rare case though, where Thanks. I will send a fix for this. -- viresh