From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Juri Lelli <Juri.Lelli@arm.com>,
Robin Randhawa <robin.randhawa@arm.com>,
Steve Muckle <smuckle.linux@gmail.com>
Subject: Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only used in slow path
Date: Thu, 24 Nov 2016 11:42:03 +0530 [thread overview]
Message-ID: <20161124061203.GF9376@vireshk-i7> (raw)
In-Reply-To: <20161124045337.GB18417@gmail.com>
On 24-11-16, 05:53, Ingo Molnar wrote:
>
> Firstly, please start changes to scheduler code with a verb. This title:
>
> Subject: Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only used in slow path
>
> is totally inadequate as it's a statement that says nothing about the _change_.
>
> What does the patch do? Does it add, remove, modify, fix or clean up?
Thanks for the tip. I have sometimes seen similar subjects-line in patches from
core developers and so thought it might be right. But yes I understand what you
are saying and will take care of this in future across all subsystems.
> * Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> > Execute the irq-work specific initialization/exit code only when the
> > fast path isn't available.
>
> Is this an optimization? A correctness fix?
Its an optimization but yeah I will try to explain a bit more next time.
--
viresh
next prev parent reply other threads:[~2016-11-24 6:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 8:23 [PATCH V2 0/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar
2016-11-15 8:23 ` [PATCH V2 1/4] cpufreq: schedutil: Avoid indented labels Viresh Kumar
2016-11-15 8:23 ` [PATCH V2 2/4] cpufreq: schedutil: enable fast switch earlier Viresh Kumar
2016-11-15 8:23 ` [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar
2016-11-16 15:26 ` Peter Zijlstra
2016-11-24 1:19 ` Rafael J. Wysocki
2016-11-24 4:51 ` Ingo Molnar
2016-11-24 5:10 ` Viresh Kumar
2016-11-15 8:23 ` [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only used in slow path Viresh Kumar
2016-11-24 4:53 ` Ingo Molnar
2016-11-24 6:12 ` Viresh Kumar [this message]
2016-11-24 6:24 ` Ingo Molnar
2016-11-24 3:01 ` [PATCH V2 0/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Steve Muckle
2016-11-24 4:04 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124061203.GF9376@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=Juri.Lelli@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=robin.randhawa@arm.com \
--cc=smuckle.linux@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox