From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work() function Date: Thu, 24 Nov 2016 09:45:36 +0100 Message-ID: <20161124084536.GA17988@gmail.com> References: <94dc68617a6c8e42de4f225b1860d9d65d11b4aa.1479975620.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <94dc68617a6c8e42de4f225b1860d9d65d11b4aa.1479975620.git.viresh.kumar@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar Cc: Rafael Wysocki , Ingo Molnar , Peter Zijlstra , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot List-Id: linux-pm@vger.kernel.org * Viresh Kumar wrote: > This patch rectifies a comment present in sugov_irq_work() function to > follow proper grammar. > > Suggested-by: Ingo Molnar > Signed-off-by: Viresh Kumar > --- > kernel/sched/cpufreq_schedutil.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c > index 42a220e78f00..71e1a980d40a 100644 > --- a/kernel/sched/cpufreq_schedutil.c > +++ b/kernel/sched/cpufreq_schedutil.c > @@ -315,15 +315,15 @@ static void sugov_irq_work(struct irq_work *irq_work) > sg_policy = container_of(irq_work, struct sugov_policy, irq_work); > > /* > + * For Real Time and Deadline tasks, the schedutil governor shoots the > + * frequency to maximum. Special care must be taken to ensure that this > + * kthread doesn't result in the same behavior. > * > * This is (mostly) guaranteed by the work_in_progress flag. The flag is > + * updated only at the end of the sugov_work() function and before that > + * the schedutil governor rejects all other frequency scaling requests. > * > + * There is a very rare case though, where the RT thread yields right > * after the work_in_progress flag is cleared. The effects of that are > * neglected for now. > */ Also: s/Real Time task/RT task s/Deadline task/deadline task With those: Acked-by: Ingo Molnar Thanks, Ingo