From: Viresh Kumar <viresh.kumar@linaro.org>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
vireshk@kernel.org, nm@ti.com, sboyd@codeaurora.org,
rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz,
gregkh@linuxfoundation.org
Subject: Re: [PATCH] PM / OPP: fix CPU device to be removed from OPP table in wrong order
Date: Fri, 25 Nov 2016 12:27:39 +0530 [thread overview]
Message-ID: <20161125065739.GC29969@vireshk-i7> (raw)
In-Reply-To: <583799EC.4060101@samsung.com>
On 25-11-16, 10:54, Joonyoung Shim wrote:
> I found this problem during system suspend/resume of Odroid-XU3 board.
>
> # rtcwake -m mem -s 3
> wakeup from "mem" at Wed Apr 4 05:54:44 2001
> [ 15.965996] PM: Syncing filesystems ... done.
> [ 15.976333] Freezing user space processes ... (elapsed 0.002 seconds) done.
> [ 15.983287] Freezing remaining freezable tasks ... (elapsed 0.002 seconds) done.
> [ 16.006951] wake enabled for irq 135
> [ 16.008782] smsc95xx 1-1.1:1.0 eth0: entering SUSPEND2 mode
> [ 16.094110] PM: suspend of devices complete after 95.038 msecs
> [ 16.105648] PM: late suspend of devices complete after 6.903 msecs
> [ 16.116356] PM: noirq suspend of devices complete after 5.912 msecs
> [ 16.121213] Disabling non-boot CPUs ...
> [ 16.154140] IRQ51 no longer affine to CPU1
> [ 16.154709] CPU1: shutdown
> [ 16.214148] IRQ52 no longer affine to CPU2
> [ 16.214646] CPU2: shutdown
> [ 16.273980] IRQ53 no longer affine to CPU3
> [ 16.274458] CPU3: shutdown
> [ 16.335093] IRQ54 no longer affine to CPU4
> [ 16.336033] CPU4: shutdown
> [ 16.389979] IRQ55 no longer affine to CPU5
> [ 16.390823] CPU5: shutdown
> [ 16.444829] IRQ56 no longer affine to CPU6
> [ 16.445621] CPU6: shutdown
> [ 16.509229] cpu cpu4: Failed to find opp_table: -19
> [ 16.514008] IRQ57 no longer affine to CPU7
> [ 16.514824] CPU7: shutdown
Hi,
Yes you have found a real bug it seems. I think that can be reproduced
by a simple rmmmod of cpufreq-dt.ko module as well.
Though the solution you provided isn't good enough.
Consider for example a case where you do this:
- offline CPU 4
- suspend the system
You are going to get stuck in the exact same problem again.
I have sent a separate patch and cc'd you. Can you please verify that
it works for you ?
--
viresh
next prev parent reply other threads:[~2016-11-25 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 7:49 [PATCH] PM / OPP: fix CPU device to be removed from OPP table in wrong order Joonyoung Shim
2016-11-24 8:34 ` Viresh Kumar
2016-11-25 1:54 ` Joonyoung Shim
2016-11-25 6:57 ` Viresh Kumar [this message]
2016-11-25 7:30 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161125065739.GC29969@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jy0922.shim@samsung.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).