From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Marcin Koss <marcin.koss@intel.com>,
Lukasz Odzioba <lukasz.odzioba@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH] powercap/intel_rapl: fix and tidy up error handling
Date: Mon, 28 Nov 2016 09:31:03 -0800 [thread overview]
Message-ID: <20161128093103.3cb4041c@jacob-builder> (raw)
In-Reply-To: <CAJZ5v0jJ4kxcT0MVi3mz0zKRrEiRaNfQqPvY6y5bTHpkPpiU3A@mail.gmail.com>
On Thu, 24 Nov 2016 22:06:59 +0100
"Rafael J. Wysocki" <rafael@kernel.org> wrote:
> On Wed, Nov 23, 2016 at 8:01 PM, Jacob Pan
> <jacob.jun.pan@linux.intel.com> wrote:
> > Commit e1399ba20eee ("powercap / RAPL: handle missing MSRs") added
> > contraint_to_pl() function to return index into an array. But it
> > can potentially return -EINVAL if powercap layer sends an out of
> > range constraint ID. This patch adds sanity check.
> >
> > Unnecessary RAPL domain pointer check is removed since it must be
> > initialized before calling rapl_unit_xlate().
> >
> > Reported-by: Odzioba, Lukasz <lukasz.odzioba@intel.com>
> > Reported-by: Koss, Marcin <marcin.koss@intel.com>
>
> Does this depend on the Thomas' series only?
>
yes, it is on top of Thomas' series.
> Also, it looks like a Fixes: tag should be present here.
>
OK. will add that.
> >
> > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
>
> Thanks,
> Rafael
[Jacob Pan]
next prev parent reply other threads:[~2016-11-28 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 19:01 [PATCH] powercap/intel_rapl: fix and tidy up error handling Jacob Pan
2016-11-24 21:06 ` Rafael J. Wysocki
2016-11-28 17:31 ` Jacob Pan [this message]
2016-11-28 21:54 ` Jacob Pan
-- strict thread matches above, loose matches on Subject: below --
2016-11-28 21:53 Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128093103.3cb4041c@jacob-builder \
--to=jacob.jun.pan@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.odzioba@intel.com \
--cc=marcin.koss@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).