From: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Rafael Wysocki <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
Viresh Kumar <vireshk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vincent Guittot
<vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
d-gerlach-l0cyMroinI0@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V6 06/10] PM / OPP: Add infrastructure to manage multiple regulators
Date: Thu, 1 Dec 2016 16:29:29 +0530 [thread overview]
Message-ID: <20161201105929.GC7682@vireshk-i7> (raw)
In-Reply-To: <20161201005149.GQ3288@vireshk-i7>
On 01-12-16, 06:21, Viresh Kumar wrote:
> On 30-11-16, 14:37, Stephen Boyd wrote:
> > > +static bool opp_debug_create_supplies(struct dev_pm_opp *opp,
> > > + struct opp_table *opp_table,
> > > + struct dentry *pdentry)
> > > +{
> > > + struct dentry *d;
> > > + int i = 0;
> > > + char *name;
> > > +
> > > + /* Always create at least supply-0 directory */
> > > + do {
> > > + name = kasprintf(GFP_KERNEL, "supply-%d", i);
> >
> > Sorry I haven't noticed this before. Wouldn't we want to put the
> > supply name here instead of a number?
>
> The OPP core provides a way for platforms to use the set-OPP
> functionality, but that is not compulsory for its user. Which makes it
> very much possible that the OPP core wouldn't know the names of the
> supplies at all. And so I used the numbers here. Anyway, the numbers
> matches the order in which they are passed from DT, so that should be
> readable.
>
> Here is the new rebased version of the patch. I will send the complete
> series again later on. Please see if it looks fine.
>
> -------------------------8<-------------------------
>
> From: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Date: Tue, 4 Oct 2016 17:07:28 +0530
> Subject: [PATCH] PM / OPP: Add infrastructure to manage multiple regulators
>
> This patch adds infrastructure to manage multiple regulators and updates
> the only user (cpufreq-dt) of dev_pm_opp_set{put}_regulator().
>
> This is preparatory work for adding full support for devices with
> multiple regulators.
>
> Signed-off-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Tested-by: Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org>
Ignore this one now. I have resent the series again after resolving
all the pending issues. Please review that.
Thanks.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-12-01 10:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 5:14 [PATCH V6 00/10] PM / OPP: Multiple regulator support Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 02/10] PM / OPP: Reword binding supporting multiple regulators per device Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 04/10] PM / OPP: Manage supply's voltage/current in a separate structure Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 05/10] PM / OPP: Pass struct dev_pm_opp_supply to _set_opp_voltage() Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 07/10] PM / OPP: Separate out _generic_set_opp() Viresh Kumar
[not found] ` <cover.1480481312.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-11-30 5:14 ` [PATCH V6 01/10] PM / OPP: Fix incorrect cpu-supply property in binding Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 03/10] PM / OPP: Don't use OPP structure outside of rcu protected section Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 06/10] PM / OPP: Add infrastructure to manage multiple regulators Viresh Kumar
[not found] ` <3b3ce1dac198fb668b97e81490bcbcf03d31e40d.1480481312.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-11-30 22:37 ` Stephen Boyd
2016-12-01 0:51 ` Viresh Kumar
2016-12-01 10:59 ` Viresh Kumar [this message]
2016-11-30 5:14 ` [PATCH V6 08/10] PM / OPP: Allow platform specific custom set_opp() callbacks Viresh Kumar
2016-11-30 22:04 ` Stephen Boyd
[not found] ` <20161130220419.GL6095-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-12-01 0:27 ` Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 09/10] PM / OPP: Don't WARN on multiple calls to dev_pm_opp_set_regulators() Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 10/10] PM / OPP: Don't assume platform doesn't have regulators Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201105929.GC7682@vireshk-i7 \
--to=viresh.kumar-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=d-gerlach-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=vireshk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).