From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH] PM / OPP: fix odd_ptr_err.cocci warnings Date: Mon, 5 Dec 2016 08:44:12 +0530 Message-ID: <20161205031412.GA29595@vireshk-i7> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f171.google.com ([209.85.192.171]:36360 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbcLEDOQ (ORCPT ); Sun, 4 Dec 2016 22:14:16 -0500 Received: by mail-pf0-f171.google.com with SMTP id 189so60674810pfz.3 for ; Sun, 04 Dec 2016 19:14:15 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Julia Lawall Cc: philip.li@intel.com, linux-pm@vger.kernel.org, kbuild-all@01.org On 02-12-16, 16:13, Julia Lawall wrote: > PTR_ERR should access the value just tested by IS_ERR > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > Signed-off-by: Julia Lawall > Signed-off-by: Fengguang Wu > --- > > I haven't checked the context, but the code looks suspicious. > > This is derived from the following tree: > > tree: https://git.linaro.org/people/vireshk/linux opp/redesign > head: fbf8f0c337a7cfcd4cb67865b5ea710e69c21f1f > commit: 5fe43a6b46470d22938bc443cf0ea20ed01a93b6 [32/33] PM / OPP: Take > kref from _find_opp_table() > :::::: branch date: 4 hours ago > :::::: commit date: 4 hours ago > > core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/base/power/opp/core.c > +++ b/drivers/base/power/opp/core.c > @@ -644,7 +644,7 @@ int dev_pm_opp_set_rate(struct device *d > if (IS_ERR(clk)) { > dev_err(dev, "%s: No clock available for the device\n", > __func__); > - ret = PTR_ERR(opp_table); > + ret = PTR_ERR(clk); > goto put_opp_table; > } Fixed, thanks. -- viresh