From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH 04/10] PM / OPP: Error out on failing to add static OPPs for v1 bindings
Date: Wed, 7 Dec 2016 13:13:43 -0800 [thread overview]
Message-ID: <20161207211343.GA5423@codeaurora.org> (raw)
In-Reply-To: <20161207032555.GE31255@vireshk-i7>
On 12/07, Viresh Kumar wrote:
> On 06-12-16, 17:17, Stephen Boyd wrote:
> > On 12/06, Viresh Kumar wrote:
> > > The code adding static OPPs for V2 bindings already does so. Make the V1
> > > bindings specific code behave the same.
> > >
> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > ---
> >
> > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> >
> > It looks like that goes back to the original DT OPP binding
> > support written by Shawn Guo. Any idea why we kept trying to add
> > more OPPs if it failed to add one? Best effort or something?
>
> Not sure, maybe for handling duplicate OPPs.
>
So perhaps we should Cc Shawn Guo who wrote the original code
then?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-12-07 21:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 9:15 [PATCH 00/10] PM / OPP: Fixes and cleanups Viresh Kumar
2016-12-06 9:15 ` [PATCH 01/10] PM / OPP: Fix memory leak while adding duplicate OPPs Viresh Kumar
2016-12-07 1:09 ` Stephen Boyd
2016-12-07 3:23 ` Viresh Kumar
2016-12-06 9:15 ` [PATCH 02/10] PM / OPP: Remove useless TODO Viresh Kumar
2016-12-07 1:10 ` Stephen Boyd
2016-12-07 3:24 ` Viresh Kumar
2016-12-06 9:15 ` [PATCH 03/10] PM / OPP: Rename _allocate_opp() to _opp_allocate() Viresh Kumar
2016-12-07 1:10 ` Stephen Boyd
2016-12-06 9:15 ` [PATCH 04/10] PM / OPP: Error out on failing to add static OPPs for v1 bindings Viresh Kumar
2016-12-07 1:17 ` Stephen Boyd
2016-12-07 3:25 ` Viresh Kumar
2016-12-07 21:13 ` Stephen Boyd [this message]
2016-12-08 3:30 ` Viresh Kumar
2016-12-08 6:39 ` Shawn Guo
2016-12-08 6:45 ` Viresh Kumar
2016-12-08 14:27 ` Shawn Guo
2016-12-08 14:47 ` Viresh Kumar
2016-12-06 9:15 ` [PATCH 05/10] PM / OPP: Add light weight _opp_free() routine Viresh Kumar
2016-12-07 1:12 ` Stephen Boyd
2016-12-06 9:15 ` [PATCH 06/10] PM / OPP: Rename and split _dev_pm_opp_remove_table() Viresh Kumar
2016-12-07 1:19 ` Stephen Boyd
2016-12-06 9:15 ` [PATCH 07/10] PM / OPP: Don't allocate OPP table from _opp_allocate() Viresh Kumar
2016-12-07 1:02 ` Stephen Boyd
2016-12-07 4:17 ` Viresh Kumar
2016-12-07 22:05 ` Stephen Boyd
2016-12-08 3:45 ` Viresh Kumar
2016-12-22 0:43 ` Stephen Boyd
2016-12-06 9:16 ` [PATCH 08/10] PM / OPP: Rename dev_pm_opp_get_suspend_opp() and return OPP rate Viresh Kumar
2016-12-07 1:21 ` Stephen Boyd
2016-12-07 4:20 ` Viresh Kumar
2016-12-06 9:16 ` [PATCH 09/10] PM / OPP: Don't expose srcu_head to register notifiers Viresh Kumar
2016-12-07 1:22 ` Stephen Boyd
2016-12-06 9:16 ` [PATCH 10/10] PM / OPP: Split out part of _add_opp_table() and _remove_opp_table() Viresh Kumar
2016-12-07 1:24 ` Stephen Boyd
2016-12-07 4:25 ` Viresh Kumar
[not found] ` <CGME20161206091647epcas4p1823f471816de0ef953123a8fbdac4b1f@epcas4p1.samsung.com>
2016-12-07 0:29 ` [PATCH 09/10] PM / OPP: Don't expose srcu_head to register notifiers MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207211343.GA5423@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).