From: Pavel Machek <pavel@ucw.cz>
To: Joe Perches <joe@perches.com>
Cc: Nick Desaulniers <nick.desaulniers@gmail.com>,
rjw@rjwysocki.net, len.brown@intel.com, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: small formatting fixes
Date: Mon, 12 Dec 2016 23:22:16 +0100 [thread overview]
Message-ID: <20161212222216.GA18201@amd> (raw)
In-Reply-To: <1481567955.1764.28.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 1644 bytes --]
On Mon 2016-12-12 10:39:15, Joe Perches wrote:
> On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote:
> > A quick cleanup that passes scripts/checkpatch.pl -f <file>.
>
> You might use the --strict option for acpi files.
Please... don't encourage people more, we have enough cleanup patches
as is.
> > diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
> []
> > @@ -103,9 +103,8 @@ static long acpi_processor_ffh_cstate_probe_cpu(void *_cx)
> >
> > if (!mwait_supported[cstate_type]) {
> > mwait_supported[cstate_type] = 1;
> > - printk(KERN_DEBUG
> > - "Monitor-Mwait will be used to enter C-%d "
> > - "state\n", cx->type);
> > + pr_debug("Monitor-Mwait will be used to enter C-%d state\n",
> > + cx->type);
>
> It's generally better not to convert
> these printk(KERN_DEBUG uses.
>
> There are behavior differences between
> printk(KERN_DEBUG ...);
> and
> pr_debug(...);
>
> The first will always be emitted as long
> as the console level is appropriate.
>
> The second depends on a #define DEBUG
> before it gets emitted or a kernel
> with CONFIG_DYNAMIC_DEBUG enabled and
> this entry specifically enabled in the
> control file.
Hmm. Perhaps pr_debug should be called pr_c_debug() or something? This
is rather nice trap.
Anyway with that fixed,
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-12-12 22:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 7:25 [PATCH] ACPI: small formatting fixes Nick Desaulniers
2016-12-12 8:56 ` Pavel Machek
2016-12-12 17:56 ` Nick Desaulniers
2016-12-12 18:39 ` Joe Perches
2016-12-12 22:22 ` Pavel Machek [this message]
2016-12-12 22:32 ` Joe Perches
2016-12-12 23:08 ` Pavel Machek
2016-12-12 23:13 ` Joe Perches
2016-12-13 10:00 ` Bjørn Mork
2016-12-12 23:20 ` Nick Desaulniers
2016-12-12 23:22 ` Joe Perches
2016-12-13 19:00 ` Pavel Machek
2016-12-23 3:19 ` Nick Desaulniers
2016-12-23 12:10 ` Rafael J. Wysocki
2017-01-11 20:03 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2016-11-21 6:51 Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212222216.GA18201@amd \
--to=pavel@ucw.cz \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nick.desaulniers@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).