From: Milo Kim <woogyom.kim@gmail.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Milo Kim <woogyom.kim@gmail.com>
Subject: [PATCH v3 1/7] power: supply: tps65217: Use 'poll_task' on unloading the module
Date: Sun, 18 Dec 2016 11:54:26 +0900 [thread overview]
Message-ID: <20161218025432.20780-2-woogyom.kim@gmail.com> (raw)
In-Reply-To: <20161218025432.20780-1-woogyom.kim@gmail.com>
Use the task_struct variable for running polling thread. If polling task
is activated, then use it to stop running thread.
This is a preceding step of supporting two interrupts of TPS65217 charger,
so checking single IRQ number is not appropriate when the module is removed.
Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
---
drivers/power/supply/tps65217_charger.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c
index 9fd019f9b88c..4fe71abe1bd3 100644
--- a/drivers/power/supply/tps65217_charger.c
+++ b/drivers/power/supply/tps65217_charger.c
@@ -200,6 +200,7 @@ static int tps65217_charger_probe(struct platform_device *pdev)
struct tps65217 *tps = dev_get_drvdata(pdev->dev.parent);
struct tps65217_charger *charger;
struct power_supply_config cfg = {};
+ struct task_struct *poll_task;
int irq;
int ret;
@@ -250,14 +251,16 @@ static int tps65217_charger_probe(struct platform_device *pdev)
/* Check current state */
tps65217_charger_irq(irq, charger);
} else {
- charger->poll_task = kthread_run(tps65217_charger_poll_task,
- charger, "ktps65217charger");
- if (IS_ERR(charger->poll_task)) {
- ret = PTR_ERR(charger->poll_task);
+ poll_task = kthread_run(tps65217_charger_poll_task,
+ charger, "ktps65217charger");
+ if (IS_ERR(poll_task)) {
+ ret = PTR_ERR(poll_task);
dev_err(charger->dev,
"Unable to run kthread err %d\n", ret);
return ret;
}
+
+ charger->poll_task = poll_task;
}
return 0;
@@ -267,7 +270,7 @@ static int tps65217_charger_remove(struct platform_device *pdev)
{
struct tps65217_charger *charger = platform_get_drvdata(pdev);
- if (charger->irq == -ENXIO)
+ if (charger->poll_task)
kthread_stop(charger->poll_task);
return 0;
--
2.11.0
next prev parent reply other threads:[~2016-12-18 2:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-18 2:54 [PATCH v3 0/7] power: supply: tps65217: Support USB charger feature Milo Kim
2016-12-18 2:54 ` Milo Kim [this message]
2016-12-18 2:54 ` [PATCH v3 2/7] power: supply: tps65217: Support USB charger interrupt Milo Kim
2016-12-18 2:54 ` [PATCH v3 3/7] power: supply: tps65217: Use generic name for charger online Milo Kim
2016-12-18 2:54 ` [PATCH v3 4/7] power: supply: tps65217: Use generic name for power supply structure Milo Kim
2016-12-18 2:54 ` [PATCH v3 5/7] power: supply: tps65217: Use generic name for power supply property Milo Kim
2016-12-18 2:54 ` [PATCH v3 6/7] power: supply: tps65217: Use generic name for get_property() Milo Kim
2016-12-18 2:54 ` [PATCH v3 7/7] power: supply: tps65217: Use generic charger name Milo Kim
2016-12-18 12:28 ` [PATCH v3 0/7] power: supply: tps65217: Support USB charger feature Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161218025432.20780-2-woogyom.kim@gmail.com \
--to=woogyom.kim@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).