From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH V2 01/10] PM / OPP: Fix memory leak while adding duplicate OPPs
Date: Wed, 21 Dec 2016 16:39:43 -0800 [thread overview]
Message-ID: <20161222003943.GA8288@codeaurora.org> (raw)
In-Reply-To: <c4517fb2db294f2da5f6e306091c230210f51a75.1481085478.git.viresh.kumar@linaro.org>
On 12/07, Viresh Kumar wrote:
> There are two types of duplicate OPPs that get different behavior from
> the core:
> A). An earlier OPP is marked 'available' and has same freq/voltages as
perhaps just "A)" instead of "A)."
> the new one.
> B). An earlier OPP with same frequency, but is marked 'unavailable' OR
> doesn't have same voltages as the new one.
>
> The OPP core returns 0 for the first one, but -EEXIST for the second.
>
> While the OPP core returns 0 for the first case, its callers don't free
> the newly allocated OPP structure which isn't used anymore. Fix that by
> returning -EBUSY instead of 0, but make the callers return 0 eventually.
>
> As this isn't a critical fix, its not getting marked for stable kernel.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-12-22 0:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 4:41 [PATCH V2 00/10] PM / OPP: Fixes and cleanups Viresh Kumar
2016-12-07 4:41 ` [PATCH V2 01/10] PM / OPP: Fix memory leak while adding duplicate OPPs Viresh Kumar
2016-12-22 0:39 ` Stephen Boyd [this message]
2016-12-07 4:41 ` [PATCH V2 02/10] PM / OPP: Remove useless TODO Viresh Kumar
2016-12-07 4:41 ` [PATCH V2 03/10] PM / OPP: Rename _allocate_opp() to _opp_allocate() Viresh Kumar
2016-12-07 4:42 ` [PATCH V2 04/10] PM / OPP: Error out on failing to add static OPPs for v1 bindings Viresh Kumar
2016-12-07 4:42 ` [PATCH V2 05/10] PM / OPP: Add light weight _opp_free() routine Viresh Kumar
2016-12-07 4:42 ` [PATCH V2 06/10] PM / OPP: Rename and split _dev_pm_opp_remove_table() Viresh Kumar
2016-12-22 0:40 ` Stephen Boyd
2016-12-07 4:42 ` [PATCH V2 07/10] PM / OPP: Don't allocate OPP table from _opp_allocate() Viresh Kumar
2016-12-07 4:42 ` [PATCH V2 08/10] PM / OPP: Rename dev_pm_opp_get_suspend_opp() and return OPP rate Viresh Kumar
2016-12-22 0:37 ` Stephen Boyd
2016-12-07 4:42 ` [PATCH V2 09/10] PM / OPP: Don't expose srcu_head to register notifiers Viresh Kumar
2016-12-07 4:42 ` [PATCH V2 10/10] PM / OPP: Split out part of _add_opp_table() and _remove_opp_table() Viresh Kumar
2016-12-08 0:07 ` [PATCH V2 00/10] PM / OPP: Fixes and cleanups Rafael J. Wysocki
2016-12-08 4:03 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161222003943.GA8288@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).