From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2] ARM: dts: Add missing CPU frequencies for Exynos5422/5800 Date: Thu, 29 Dec 2016 16:17:07 +0200 Message-ID: <20161229141707.qjrtjz7dik6a7l5s@kozik-lap> References: <10512254.nyUcL0zgTP@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:36123 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752668AbcL2ORQ (ORCPT ); Thu, 29 Dec 2016 09:17:16 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Doug Anderson Cc: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Kukjin Kim , Javier Martinez Canillas , Rob Herring , Mark Rutland , Russell King , Andreas Faerber , Thomas Abraham , Ben Gamari , Arjun K V , linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" On Thu, Dec 15, 2016 at 04:54:30PM -0800, Doug Anderson wrote: > > Index: b/arch/arm/boot/dts/exynos5800.dtsi > > =================================================================== > > --- a/arch/arm/boot/dts/exynos5800.dtsi 2016-12-15 12:43:54.365955950 +0100 > > +++ b/arch/arm/boot/dts/exynos5800.dtsi 2016-12-15 12:43:54.361955949 +0100 > > @@ -24,6 +24,16 @@ > > }; > > > > &cluster_a15_opp_table { > > + opp@2000000000 { > > + opp-hz = /bits/ 64 <2000000000>; > > + opp-microvolt = <1250000>; > > + clock-latency-ns = <140000>; > > + }; > > + opp@1900000000 { > > + opp-hz = /bits/ 64 <1900000000>; > > + opp-microvolt = <1250000>; > > + clock-latency-ns = <140000>; > > + }; > > I don't think the voltages you listed are high enough for all peach pi > boards for A15 at 1.9 GHz and 2.0 GHz, at least based on the research > I did. See my response to v1. I wanted to apply this but saw this remaining issue. Javier tested it on Peach Pi so is this concern still valid? Bartlomiej, When sending dts patches please stick to the common subsystem prefix (git log --oneline arch/arm/boot/dts/exynos*). Best regards, Krzysztof