* [PATCH] irqchip: mxs: Enable SKIP_SET_WAKE and MASK_ON_SUSPEND
@ 2016-12-27 18:29 Stefan Wahren
2016-12-28 15:47 ` Fabio Estevam
2016-12-31 19:41 ` Jason Cooper
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Wahren @ 2016-12-27 18:29 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: Marek Vasut, Stefan Wahren, linux-pm, Oleksij Rempel,
Sascha Hauer, Fabio Estevam, Shawn Guo, linux-arm-kernel,
Lothar Waßmann
The ICOLL controller doesn't provide any facility to configure the
wakeup sources. That's the reason why this implementation lacks
the irq_set_wake implementation. But this prevent us from properly
entering power management states like "suspend to idle".
So enable the flags IRQCHIP_SKIP_SET_WAKE and
IRQCHIP_MASK_ON_SUSPEND to let the irqchip core allows and handles
the power management.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/irqchip/irq-mxs.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c
index 1730470..05fa9f7 100644
--- a/drivers/irqchip/irq-mxs.c
+++ b/drivers/irqchip/irq-mxs.c
@@ -131,12 +131,16 @@ static void asm9260_unmask_irq(struct irq_data *d)
.irq_ack = icoll_ack_irq,
.irq_mask = icoll_mask_irq,
.irq_unmask = icoll_unmask_irq,
+ .flags = IRQCHIP_MASK_ON_SUSPEND |
+ IRQCHIP_SKIP_SET_WAKE,
};
static struct irq_chip asm9260_icoll_chip = {
.irq_ack = icoll_ack_irq,
.irq_mask = asm9260_mask_irq,
.irq_unmask = asm9260_unmask_irq,
+ .flags = IRQCHIP_MASK_ON_SUSPEND |
+ IRQCHIP_SKIP_SET_WAKE,
};
asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] irqchip: mxs: Enable SKIP_SET_WAKE and MASK_ON_SUSPEND
2016-12-27 18:29 [PATCH] irqchip: mxs: Enable SKIP_SET_WAKE and MASK_ON_SUSPEND Stefan Wahren
@ 2016-12-28 15:47 ` Fabio Estevam
2016-12-31 19:41 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-12-28 15:47 UTC (permalink / raw)
To: Stefan Wahren
Cc: Thomas Gleixner, Jason Cooper, Marc Zyngier, Marek Vasut,
linux-pm@vger.kernel.org, Oleksij Rempel, Sascha Hauer,
Fabio Estevam, Shawn Guo, linux-arm-kernel@lists.infradead.org,
Lothar Waßmann
On Tue, Dec 27, 2016 at 4:29 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> The ICOLL controller doesn't provide any facility to configure the
> wakeup sources. That's the reason why this implementation lacks
> the irq_set_wake implementation. But this prevent us from properly
> entering power management states like "suspend to idle".
>
> So enable the flags IRQCHIP_SKIP_SET_WAKE and
> IRQCHIP_MASK_ON_SUSPEND to let the irqchip core allows and handles
> the power management.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip: mxs: Enable SKIP_SET_WAKE and MASK_ON_SUSPEND
2016-12-27 18:29 [PATCH] irqchip: mxs: Enable SKIP_SET_WAKE and MASK_ON_SUSPEND Stefan Wahren
2016-12-28 15:47 ` Fabio Estevam
@ 2016-12-31 19:41 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Jason Cooper @ 2016-12-31 19:41 UTC (permalink / raw)
To: Stefan Wahren
Cc: Marek Vasut, linux-pm, Marc Zyngier, Oleksij Rempel, Sascha Hauer,
Fabio Estevam, Thomas Gleixner, Shawn Guo, linux-arm-kernel,
Lothar Waßmann
Hi Stefan,
On Tue, Dec 27, 2016 at 06:29:57PM +0000, Stefan Wahren wrote:
> The ICOLL controller doesn't provide any facility to configure the
> wakeup sources. That's the reason why this implementation lacks
> the irq_set_wake implementation. But this prevent us from properly
> entering power management states like "suspend to idle".
>
> So enable the flags IRQCHIP_SKIP_SET_WAKE and
> IRQCHIP_MASK_ON_SUSPEND to let the irqchip core allows and handles
> the power management.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> drivers/irqchip/irq-mxs.c | 4 ++++
> 1 file changed, 4 insertions(+)
Applied to irqchip/urgent with Fabio's Reviewed-by.
thx,
Jason.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-31 19:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-27 18:29 [PATCH] irqchip: mxs: Enable SKIP_SET_WAKE and MASK_ON_SUSPEND Stefan Wahren
2016-12-28 15:47 ` Fabio Estevam
2016-12-31 19:41 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).