From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation Date: Mon, 2 Jan 2017 12:39:03 +0530 Message-ID: <20170102070903.GC8588@vireshk-i7> References: <20161216090625.2235668-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pg0-f41.google.com ([74.125.83.41]:36450 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbdABHJH (ORCPT ); Mon, 2 Jan 2017 02:09:07 -0500 Received: by mail-pg0-f41.google.com with SMTP id f188so201059210pgc.3 for ; Sun, 01 Jan 2017 23:09:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <20161216090625.2235668-1-arnd@arndb.de> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Arnd Bergmann Cc: Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , "Rafael J. Wysocki" , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org On 16-12-16, 10:06, Arnd Bergmann wrote: > s3c64xx_cpufreq_config_regulator is incorrectly annotated > as __init, since the caller is also not init: > > WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator() > > With modern gcc versions, the function gets inline, so we don't > see the warning, this only happens with gcc-4.6 and older. > > Signed-off-by: Arnd Bergmann > --- > drivers/cpufreq/s3c64xx-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c > index 176e84cc3991..0cb9040eca49 100644 > --- a/drivers/cpufreq/s3c64xx-cpufreq.c > +++ b/drivers/cpufreq/s3c64xx-cpufreq.c > @@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy, > } > > #ifdef CONFIG_REGULATOR > -static void __init s3c64xx_cpufreq_config_regulator(void) > +static void s3c64xx_cpufreq_config_regulator(void) > { > int count, v, i, found; > struct cpufreq_frequency_table *freq; Acked-by: Viresh Kumar -- viresh