From: Sebastian Reichel <sre@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power_supply: wm97xx_battery: remove redundant 2nd null check on pdata
Date: Wed, 4 Jan 2017 22:21:12 +0100 [thread overview]
Message-ID: <20170104212112.dws54sse2xnjgtfv@earth> (raw)
In-Reply-To: <20161229152312.20537-1-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 534 bytes --]
Hi Colin,
On Thu, Dec 29, 2016 at 03:23:12PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> pdata is being null checked twice, the 2nd check is redundant code
> and can be removed.
>
> Fixes CoverityScan CID 1392340 "Logically dead code"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks for your patch. I have queued it into power-supply's
for-next branch:
https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-01-04 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 15:23 [PATCH] power_supply: wm97xx_battery: remove redundant 2nd null check on pdata Colin King
2017-01-04 21:21 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104212112.dws54sse2xnjgtfv@earth \
--to=sre@kernel.org \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox