From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2 4/6] power: bq24190_charger: Call power_supply_changed() for relevant component Date: Mon, 16 Jan 2017 18:30:59 -0800 Message-ID: <20170117023058.GD7399@atomide.com> References: <20170116183125.GE27262@animalcreek.com> <20170117015424.GB2926@animalcreek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from muru.com ([72.249.23.125]:57852 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbdAQCbo (ORCPT ); Mon, 16 Jan 2017 21:31:44 -0500 Content-Disposition: inline In-Reply-To: <20170117015424.GB2926@animalcreek.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Mark Greer Cc: Liam Breck , linux-pm@vger.kernel.org, Sebastian Reichel , Liam Breck , Matt Ranostay * Mark Greer [170116 17:55]: > On Mon, Jan 16, 2017 at 11:55:22AM -0800, Liam Breck wrote: > > On Mon, Jan 16, 2017 at 10:31 AM, Mark Greer wrote: > > > On Sun, Jan 15, 2017 at 10:08:04PM -0800, Liam Breck wrote: > > >> > > > > > >> We wrongly get uevents for bq24190-charger and bq24190-battery on every > > >> register change. > > >> > > >> Fix by checking the association with charger and battery before > > >> emitting uevent(s). > > >> > > >> Fixes: d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190 Battery Charger") > > >> Cc: Mark A. Greer > > >> Cc: Matt Ranostay > > >> Cc: Tony Lindgren > > >> Signed-off-by: Liam Breck > > >> --- > > >> drivers/power/supply/bq24190_charger.c | 50 +++++++++++++++++++--------------- > > >> 1 file changed, 27 insertions(+), 23 deletions(-) > > >> > > >> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c > > >> index 62194d8..ba5a5b2 100644 > > >> --- a/drivers/power/supply/bq24190_charger.c > > >> +++ b/drivers/power/supply/bq24190_charger.c > > > > > >> @@ -1225,8 +1227,12 @@ static irqreturn_t bq24190_irq_handler_thread(int irq, void *data) > > >> ret); > > >> } > > >> > > >> + if ((bdi->ss_reg & battery_mask_ss) != (ss_reg & battery_mask_ss)) > > >> + alert_battery = true; > > >> + if ((bdi->ss_reg & ~battery_mask_ss) != (ss_reg & ~battery_mask_ss)) > > > > > > Lines are > 80 characters. Please break up. > > > > I did this deliberately, because the same logic appears for f_reg in > > that function, and this way you can see that at a glance. > > That's because those lines are <= 80 chars. :) > > > My research on 80-char limit found that it's not a hard rule. > > Section 2 of Documentation/process/coding-style.rst makes it pretty clear > along with exceptions. Yeah and it's a good idea to avoid anything that can cause extra discussion for nothing ;) Tony