From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, xf@rock-chips.com, heiko@sntech.de,
rjw@rjwysocki.net, khilman@kernel.org, ulf.hansson@linaro.org,
pavel@ucw.cz, len.brown@intel.com, gregkh@linuxfoundation.org,
linux-pm@vger.kernel.org, huangtao@rock-chips.com,
xxx@rock-chips.com, wxt@rock-chips.com,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Elaine Zhang <zhangqing@rock-chips.com>
Subject: Re: [PATCH v1] PM / Domains: Keep the pd status during system PM phases
Date: Fri, 20 Jan 2017 10:15:54 +0800 [thread overview]
Message-ID: <201701201047.juTmuxEo%fengguang.wu@intel.com> (raw)
In-Reply-To: <1484794273-30103-1-git-send-email-zhangqing@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 5155 bytes --]
Hi Elaine,
[auto build test WARNING on pm/linux-next]
[also build test WARNING on v4.10-rc4 next-20170119]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Elaine-Zhang/PM-Domains-Keep-the-pd-status-during-system-PM-phases/20170120-091738
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-x016-201703 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from include/linux/linkage.h:4:0,
from include/linux/kernel.h:6,
from include/linux/delay.h:10,
from drivers/base/power/domain.c:9:
drivers/base/power/domain.c: In function 'pm_genpd_suspend_noirq':
drivers/base/power/domain.c:885:29: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/base/power/domain.c:884:2: note: in expansion of macro 'if'
if (genpd->suspend_power_off ||
^~
drivers/base/power/domain.c:885:29: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:149:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/base/power/domain.c:884:2: note: in expansion of macro 'if'
if (genpd->suspend_power_off ||
^~
drivers/base/power/domain.c:885:29: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:160:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^~~~
>> drivers/base/power/domain.c:884:2: note: in expansion of macro 'if'
if (genpd->suspend_power_off ||
^~
drivers/base/power/domain.c: In function 'pm_genpd_resume_noirq':
drivers/base/power/domain.c:923:29: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
drivers/base/power/domain.c:922:2: note: in expansion of macro 'if'
if (genpd->suspend_power_off ||
^~
drivers/base/power/domain.c:923:29: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:149:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
drivers/base/power/domain.c:922:2: note: in expansion of macro 'if'
if (genpd->suspend_power_off ||
^~
drivers/base/power/domain.c:923:29: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:160:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^~~~
drivers/base/power/domain.c:922:2: note: in expansion of macro 'if'
if (genpd->suspend_power_off ||
^~
vim +/if +884 drivers/base/power/domain.c
868 * @dev: Device to suspend.
869 *
870 * Stop the device and remove power from the domain if all devices in it have
871 * been stopped.
872 */
873 static int pm_genpd_suspend_noirq(struct device *dev)
874 {
875 struct generic_pm_domain *genpd;
876 int ret;
877
878 dev_dbg(dev, "%s()\n", __func__);
879
880 genpd = dev_to_genpd(dev);
881 if (IS_ERR(genpd))
882 return -EINVAL;
883
> 884 if (genpd->suspend_power_off ||
885 dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
886 return 0;
887
888 if (genpd->dev_ops.stop && genpd->dev_ops.start) {
889 ret = pm_runtime_force_suspend(dev);
890 if (ret)
891 return ret;
892 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23233 bytes --]
prev parent reply other threads:[~2017-01-20 2:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 2:51 [PATCH v1] PM / Domains: Keep the pd status during system PM phases Elaine Zhang
2017-01-20 2:11 ` kbuild test robot
2017-01-20 2:15 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201701201047.juTmuxEo%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kbuild-all@01.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
--cc=wxt@rock-chips.com \
--cc=xf@rock-chips.com \
--cc=xxx@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox