Re: [PATCH v3 01/13] soc: samsung: pmu: Provide global function to get PMU regmap

Krzysztof Kozlowski
2017-01-26T14:41:55Z

On Thu, Jan 26, 2017 at 11:43 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> On Thu, Jan 19, 2017 at 2:48 PM, Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>
>> PMU is something like a SoC wide service, so add a helper function to get
>> PMU regmap. This will be used by other Exynos device drivers. This way it
>> can be avoided to model this dependency in device tree (as phandles to PMU
>> node) for almost every device in the SoC.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>
>
> But why? I could understand it as a local header in
> drivers/soc/samsung/*.h for those files.

Marek gave quite detailed answer... so let me just add minor note.
Apparently we cannot satisfy everyone. When break the DT ABI, DT
people are not happy. When we try to avoid ABI break, we create such
dependency.

In fact, such compile and runtime dependency is not unusual. Our
drivers are coupled because our hardware modules are coupled. When
they were put in arch/arm/mach-exynos, no one cared because everything
was contained in mach-exynos. We try to move the code out of there
thus we need to model such dependencies in a new way... or break the
DT ABI.

Best regards,
Krzysztof