Re: [PATCH v3 11/13] pinctrl: samsung: Move retention control from mach-exynos to the pinctrl driver

Marek Szyprowski
2017-01-26T09:13:26Z

Hi Linus,

On 2017-01-26 10:10, Linus Walleij wrote:
> On Thu, Jan 19, 2017 at 2:48 PM, Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> This patch moves pad retention control from PMU driver to Exynos pin
>> controller driver. This helps to avoid possible ordering and logical
>> dependencies between machine, PMU and pin control code. Till now it
>> worked fine only because sys_ops for PMU and pin controller were called
>> in registration order.
>> This is also a preparation for adding new features to Exynos pin
>> controller driver, like runtime power management and suspending
>> individual pin controllers, which might be a part of some power domain.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>> Acked-by: Tomasz Figa <tomasz.figa@gmail.com>
>> ---
>> arch/arm/mach-exynos/suspend.c | 64 --------------
>> drivers/pinctrl/samsung/pinctrl-exynos.c | 145 +++++++++++++++++++++++++++++++
> This makes all kind of sense, but I would ideally like an ACK
> from the ARM SoC maintainer(s): Arnd, Olof, are you OK with
> this?

Isn't enough to have Krzysztof's (Exynos SoC maintainer) 'reviewed-by' tag?
I assume that 'reviewed-by' also includes 'acked-by'.

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland