From: Viresh Kumar <viresh.kumar@linaro.org>
To: Philipp Miedl <philipp.miedl@tik.ee.ethz.ch>
Cc: alex@digriz.org.uk, jun.nakajima@intel.com,
venkatesh.pallipadi@intel.com,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: Delayed acpi frequency governor call
Date: Mon, 23 Jan 2017 15:41:45 +0530 [thread overview]
Message-ID: <20170123101145.GB26681@vireshk-i7> (raw)
In-Reply-To: <9b332b49-11a1-a5fc-d48e-2c113cdca202@tik.ee.ethz.ch>
On 20-01-17, 16:27, Philipp Miedl wrote:
> This is not my issue. The code I'm referring to can be found in
> cpufreq_governor.c:
> <-->
> if (unlikely(wall_time > (2 * sampling_rate) &&
> j_cdbs->prev_load)) {
This only confirms that the CPU was idle for sometime.
> load = j_cdbs->prev_load;
>
> /*
> * Perform a destructive copy, to ensure that we copy
> * the previous load only once, upon the first wake-up
> * from idle.
> */
> j_cdbs->prev_load = 0;
> } else {
> load = 100 * (wall_time - idle_time) / wall_time;
> j_cdbs->prev_load = load;
> }
> <-->
>
> How can it happen that "unlikely(wall_time > (2 * sampling_rate)" is true
> although the CPU utilization was 5%?
I am not sure how your test works, etc. Maybe try to generate traces for your
CPUs to see if they are going into idle or not. Maybe you are having a hard time
because of SMP platform ?
--
viresh
next prev parent reply other threads:[~2017-01-23 10:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c8ee7078-ad5a-0a23-66ae-620c507300e5@tik.ee.ethz.ch>
2017-01-20 10:07 ` Delayed acpi frequency governor call Viresh Kumar
2017-01-20 15:27 ` Philipp Miedl
2017-01-23 10:11 ` Viresh Kumar [this message]
2017-01-23 14:24 ` Philipp Miedl
2017-01-24 4:22 ` Viresh Kumar
2017-01-24 14:49 ` Philipp Miedl
2017-01-25 3:23 ` Viresh Kumar
2017-01-25 9:48 ` Philipp Miedl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123101145.GB26681@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=alex@digriz.org.uk \
--cc=jun.nakajima@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=philipp.miedl@tik.ee.ethz.ch \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox