From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 0/8] Power domains support for Exynos5433 SoCs Date: Fri, 27 Jan 2017 09:52:32 +0200 Message-ID: <20170127075232.it4c4e7a3hno7i7e@kozik-lap> References: <1485345342-3273-1-git-send-email-m.szyprowski@samsung.com> <20170127074346.iwzaavl2lnu64uxq@kozik-lap> <6cbea032-86a3-20b9-6cdf-93099f553531@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <6cbea032-86a3-20b9-6cdf-93099f553531@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Marek Szyprowski Cc: linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Chanwoo Choi , Inki Dae List-Id: linux-pm@vger.kernel.org On Fri, Jan 27, 2017 at 08:47:44AM +0100, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2017-01-27 08:43, Krzysztof Kozlowski wrote: > > On Wed, Jan 25, 2017 at 12:55:34PM +0100, Marek Szyprowski wrote: > > > Hello, > > > > > > This patchset is a final step to add support for all power domains > > > on Exynos5433 SoCs. This patchset contains patches for adding Exynos5433 > > > support to Exynos power domain driver and definitions of all power > > > domains found in Exynos5433 SoCs. > > > > > > Patches have been generated on top of linux-next from 25th January 2017. > > > > > > This is a part of a larger task, which goal is to add support for power > > > domains on Exynos5433 SoCs / TM2 boards. All patches needed to get it > > > working have been pushed to the following git repo: > > > https://git.linaro.org/people/marek.szyprowski/linux-srpol.git v4.10-next-tm2-pd > > > > > > To get everything working following patches/patchsets are needed on top > > > of the linux-next tree: > > By "get everything working" you also mean that there is a runtime > > dependency? In other words, can I apply DTS patches here? > > IMHO we should wait with applying pm domains DTS patches. Without ALL other > patches > kernel will sooner or later panic with "(a)synchronous external abort" or > deadlock > in a different way. Okay, makes sense. A partial solution would be to apply them with status=disabled. After all it is still a valid description of a hardware. However this would not bring much benefits anyway... Beside the name of node I mentioned, please put all the power domains sorted to each other by address. I see the big picture here: https://git.linaro.org/people/marek.szyprowski/linux-srpol.git/tree/arch/arm64/boot/dts/exynos/exynos5433.dtsi?h=v4.10-next-tm2-pd and it does not looks ordered. Best regards, Krzysztof