From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-pm@vger.kernel.org, Lin Huang <hl@rock-chips.com>,
kbuild test robot <fengguang.wu@intel.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [pm:bleeding-edge 8/8] drivers/devfreq/devfreq.c:631:9: error: implicit declaration of function 'dev_pm_opp_get_suspend_opp'
Date: Mon, 30 Jan 2017 10:23:23 +0530 [thread overview]
Message-ID: <20170130045323.GC32580@vireshk-i7> (raw)
In-Reply-To: <1536438.yev350rkh8@aspire.rjw.lan>
On 28-01-17, 10:23, Rafael J. Wysocki wrote:
> On Saturday, January 28, 2017 08:11:14 AM kbuild test robot wrote:
> >
> > --r5Pyd7+fXNt84Ff3
> > Content-Type: text/plain; charset=us-ascii
> > Content-Disposition: inline
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> > head: a3010a64f3a78b5beab758083a58cedef710dcc0
> > commit: a3010a64f3a78b5beab758083a58cedef710dcc0 [8/8] Merge branch 'pm-opp' into bleeding-edge
> > config: x86_64-rhel (attached as .config)
> > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > reproduce:
> > git checkout a3010a64f3a78b5beab758083a58cedef710dcc0
> > # save the attached .config to linux build tree
> > make ARCH=x86_64
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/devfreq/devfreq.c: In function 'devfreq_add_device':
> > >> drivers/devfreq/devfreq.c:631:9: error: implicit declaration of function 'dev_pm_opp_get_suspend_opp' [-Werror=implicit-function-declaration]
> > opp = dev_pm_opp_get_suspend_opp(dev);
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/devfreq/devfreq.c:631:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > opp = dev_pm_opp_get_suspend_opp(dev);
> > ^
> > cc1: some warnings being treated as errors
> >
> > vim +/dev_pm_opp_get_suspend_opp +631 drivers/devfreq/devfreq.c
> >
> > 4e670b1d Lin Huang 2016-12-28 625 */
> > 4e670b1d Lin Huang 2016-12-28 626 devfreq->suspend_freq = 0L;
> > 4e670b1d Lin Huang 2016-12-28 627 if (strncmp(devfreq->governor_name, "passive", 7)) {
> > 4e670b1d Lin Huang 2016-12-28 628 struct dev_pm_opp *opp;
> > 4e670b1d Lin Huang 2016-12-28 629
> > 4e670b1d Lin Huang 2016-12-28 630 rcu_read_lock();
> > 4e670b1d Lin Huang 2016-12-28 @631 opp = dev_pm_opp_get_suspend_opp(dev);
> > 4e670b1d Lin Huang 2016-12-28 632 if (opp)
> > 4e670b1d Lin Huang 2016-12-28 633 devfreq->suspend_freq = dev_pm_opp_get_freq(opp);
> > 4e670b1d Lin Huang 2016-12-28 634 rcu_read_unlock();
> >
> > :::::: The code at line 631 was first introduced by commit
> > :::::: 4e670b1d75d939e33297601916699579e5f7218b PM / devfreq: Add suspend frequency support
>
> There seems to be some disagreement between this and the OPP changes from
> Viresh.
>
> Can you guys please see what's going on and resolve it?
I have replied to the original patch from Chanwoo and he needs to use
the new interface and resend his patch. @Chanwoo please use:
dev_pm_opp_get_suspend_opp_freq() instead.
--
viresh
next prev parent reply other threads:[~2017-01-30 4:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 0:11 [pm:bleeding-edge 8/8] drivers/devfreq/devfreq.c:631:9: error: implicit declaration of function 'dev_pm_opp_get_suspend_opp' kbuild test robot
2017-01-28 9:23 ` Rafael J. Wysocki
2017-01-30 4:53 ` Viresh Kumar [this message]
2017-01-31 0:37 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130045323.GC32580@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=fengguang.wu@intel.com \
--cc=hl@rock-chips.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).