From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Inki Dae <inki.dae@samsung.com>
Subject: Re: [PATCH v3 0/5] Provide real domain names for Exynos power domain driver
Date: Mon, 30 Jan 2017 20:36:21 +0200 [thread overview]
Message-ID: <20170130183621.3v77pfrncm2qb7nr@kozik-lap> (raw)
In-Reply-To: <1485778740-30337-1-git-send-email-m.szyprowski@samsung.com>
On Mon, Jan 30, 2017 at 01:18:55PM +0100, Marek Szyprowski wrote:
> Hi!
>
> For everyone working on power management and runtime power management it
> is important to have a meaningful information about the state of the
> power domains. Current Exynos power domain driver created names of the
> domains based on the device tree node name. Those name
> we incorrectly a bit more descriptive (like "mfc-power-domain@10023C40"
> in exynos4.dtsi) than they should be (it should be fixed to
> "power-domain@10023C40"). This patch series adds reading human readable
> names from the 'label' property. While touching this, I've also fixes
> a few obvious issues related to power domain driver code.
>
> Patches are based on the Linux next-20170130 branch.
>
> Best regards
> Marek Szyprowski
> Samsung R&D Institute Poland
>
I think I am missing something... but it looks it does not work. I
applied it on top of my for-next tree and:
cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
domain status slaves
/device runtime status
----------------------------------------------------------------------
isp-power-domain@10023CA0 off-0
gps-alive-power-domain@10023D00 off-0
gps-power-domain@10023CE0 off-0
cam-power-domain@10023C00 off-0
Also, with enabled debug on pm-domains and unbinding a device:
[ 180.016800] s5p-mfc 13400000.codec: genpd_runtime_resume()
[ 180.017289] s5p-mfc 13400000.codec: genpd_runtime_suspend()
[ 180.017519] s5p-mfc 13400000.codec: Removing 13400000.codec
[ 180.024283] s5p-mfc 13400000.codec: removing from PM domain mfc-power-domain@10023C40
[ 180.024323] s5p-mfc 13400000.codec: genpd_remove_device()
I think in both cases the genpd->name is used... which should be the new
name (label).
What is wrong?
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-01-30 18:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170130121912eucas1p1002708fc40c2d385c41ef2d7574561f9@eucas1p1.samsung.com>
2017-01-30 12:18 ` [PATCH v3 0/5] Provide real domain names for Exynos power domain driver Marek Szyprowski
[not found] ` <CGME20170130121913eucas1p22838794c26581e0b1757f2610ce9b32d@eucas1p2.samsung.com>
2017-01-30 12:18 ` [PATCH v3 1/5] soc: samsung: pm_domains: Use full names in subdomains registration log Marek Szyprowski
2017-01-31 19:35 ` Krzysztof Kozlowski
[not found] ` <CGME20170130121913eucas1p187c10b4ad4b3551c0100b492374f42bb@eucas1p1.samsung.com>
2017-01-30 12:18 ` [PATCH v3 2/5] soc: samsung: pm_domains: Remove unused name field Marek Szyprowski
2017-01-31 19:39 ` Krzysztof Kozlowski
[not found] ` <CGME20170130121924eucas1p24f99bd1ca38a37d88d54aae96d0e141f@eucas1p2.samsung.com>
2017-01-30 12:18 ` [PATCH v3 3/5] soc: samsung: pm_domains: Remove message about failed memory allocation Marek Szyprowski
2017-01-31 19:39 ` Krzysztof Kozlowski
[not found] ` <CGME20170130121915eucas1p23aa4f4be912bcd64f9521f6e6b51132f@eucas1p2.samsung.com>
2017-01-30 12:18 ` [PATCH v3 4/5] soc: samsung: pm_domains: Read domain name from the new label property Marek Szyprowski
2017-01-31 19:40 ` Krzysztof Kozlowski
2017-02-01 16:25 ` Rob Herring
2017-02-04 15:46 ` Krzysztof Kozlowski
[not found] ` <CGME20170130121915eucas1p1ee68039795d5ee4a05990fe6e27c5fcc@eucas1p1.samsung.com>
2017-01-30 12:19 ` [PATCH v3 5/5] arm: dts: exynos: Add labels to all existing power domains Marek Szyprowski
2017-01-31 19:40 ` Krzysztof Kozlowski
2017-01-30 18:36 ` Krzysztof Kozlowski [this message]
2017-01-31 7:04 ` [PATCH v3 0/5] Provide real domain names for Exynos power domain driver Marek Szyprowski
2017-01-31 19:19 ` Krzysztof Kozlowski
2017-01-31 19:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130183621.3v77pfrncm2qb7nr@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).