From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v3 0/5] Provide real domain names for Exynos power domain driver Date: Mon, 30 Jan 2017 20:36:21 +0200 Message-ID: <20170130183621.3v77pfrncm2qb7nr@kozik-lap> References: <1485778740-30337-1-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1485778740-30337-1-git-send-email-m.szyprowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Marek Szyprowski Cc: linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, Sylwester Nawrocki , Javier Martinez Canillas , Bartlomiej Zolnierkiewicz , Chanwoo Choi , Inki Dae List-Id: linux-pm@vger.kernel.org On Mon, Jan 30, 2017 at 01:18:55PM +0100, Marek Szyprowski wrote: > Hi! > > For everyone working on power management and runtime power management it > is important to have a meaningful information about the state of the > power domains. Current Exynos power domain driver created names of the > domains based on the device tree node name. Those name > we incorrectly a bit more descriptive (like "mfc-power-domain@10023C40" > in exynos4.dtsi) than they should be (it should be fixed to > "power-domain@10023C40"). This patch series adds reading human readable > names from the 'label' property. While touching this, I've also fixes > a few obvious issues related to power domain driver code. > > Patches are based on the Linux next-20170130 branch. > > Best regards > Marek Szyprowski > Samsung R&D Institute Poland > I think I am missing something... but it looks it does not work. I applied it on top of my for-next tree and: cat /sys/kernel/debug/pm_genpd/pm_genpd_summary domain status slaves /device runtime status ---------------------------------------------------------------------- isp-power-domain@10023CA0 off-0 gps-alive-power-domain@10023D00 off-0 gps-power-domain@10023CE0 off-0 cam-power-domain@10023C00 off-0 Also, with enabled debug on pm-domains and unbinding a device: [ 180.016800] s5p-mfc 13400000.codec: genpd_runtime_resume() [ 180.017289] s5p-mfc 13400000.codec: genpd_runtime_suspend() [ 180.017519] s5p-mfc 13400000.codec: Removing 13400000.codec [ 180.024283] s5p-mfc 13400000.codec: removing from PM domain mfc-power-domain@10023C40 [ 180.024323] s5p-mfc 13400000.codec: genpd_remove_device() I think in both cases the genpd->name is used... which should be the new name (label). What is wrong? Best regards, Krzysztof