From: Viresh Kumar <viresh.kumar@linaro.org>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Javi Merino <javi.merino@kernel.org>,
Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edu>
Subject: Re: [PATCH V2 07/12] PM / OPP: Update OPP users to put reference
Date: Tue, 31 Jan 2017 14:17:24 +0530 [thread overview]
Message-ID: <20170131084724.GB7458@vireshk-i7> (raw)
In-Reply-To: <20170131071721epcms1p6a4da8e0add4547573d40bbbb55d37b74@epcms1p6>
On 31-01-17, 07:17, MyungJoo Ham wrote:
> > This patch updates dev_pm_opp_find_freq_*() routines to get a reference
> > to the OPPs returned by them.
> >
> > Also updates the users of dev_pm_opp_find_freq_*() routines to call
> > dev_pm_opp_put() after they are done using the OPPs.
> >
> > As it is guaranteed the that OPPs wouldn't get freed while being used,
> > the RCU read side locking present with the users isn't required anymore.
> > Drop it as well.
> >
> > This patch also updates all users of devfreq_recommended_opp() which was
> > returning an OPP received from the OPP core.
> >
> > Note that some of the OPP core routines have gained
> > rcu_read_{lock|unlock}() calls, as those still use RCU specific APIs
> > within them.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> [Devfreq]
>
> This patch gets a lot of fails during application.
>
> For devfreq-side, I've got:
> error: drivers/devfreq/devfreq.c: patch does not apply
> error: patch failed: drivers/devfreq/exynos-bus.c:103
> error: drivers/devfreq/exynos-bus.c: patch does not apply
> error: patch failed: drivers/devfreq/governor_passive.c:59
> error: drivers/devfreq/governor_passive.c: patch does not apply
> error: patch failed: drivers/devfreq/rk3399_dmc.c:91
> error: drivers/devfreq/rk3399_dmc.c: patch does not apply
> error: patch failed: drivers/devfreq/tegra-devfreq.c:487
> error: drivers/devfreq/tegra-devfreq.c: patch does not apply
>
> With the condition that you are going to properly rebase the patch,
> you may add "Reviewed-by" from me.
> (the code itself looks fine.)
This is already applied by Rafael and was based over his tree only.
--
viresh
prev parent reply other threads:[~2017-01-31 8:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 4:41 [PATCH V2 00/12] PM / OPP: Use kref and move away from RCU locking Viresh Kumar
2017-01-23 4:41 ` [PATCH V2 01/12] PM / OPP: Add per OPP table mutex Viresh Kumar
2017-01-23 4:41 ` [PATCH V2 02/12] PM / OPP: Add 'struct kref' to OPP table Viresh Kumar
2017-01-23 4:41 ` [PATCH V2 03/12] PM / OPP: Return opp_table from dev_pm_opp_set_*() routines Viresh Kumar
2017-01-23 4:41 ` [PATCH V2 04/12] PM / OPP: Take reference of the OPP table while adding/removing OPPs Viresh Kumar
2017-01-23 4:41 ` [PATCH V2 05/12] PM / OPP: Use dev_pm_opp_get_opp_table() instead of _add_opp_table() Viresh Kumar
2017-01-23 4:41 ` [PATCH V2 06/12] PM / OPP: Add 'struct kref' to struct dev_pm_opp Viresh Kumar
[not found] ` <cover.1485146406.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-23 4:41 ` [PATCH V2 07/12] PM / OPP: Update OPP users to put reference Viresh Kumar
2017-01-23 4:41 ` [PATCH V2 08/12] PM / OPP: Take kref from _find_opp_table() Viresh Kumar
2017-01-23 4:41 ` [PATCH V2 09/12] PM / OPP: Move away from RCU locking Viresh Kumar
2017-01-23 4:41 ` [PATCH V2 10/12] PM / OPP: Simplify _opp_set_availability() Viresh Kumar
2017-01-23 4:41 ` [PATCH V2 11/12] PM / OPP: Simplify dev_pm_opp_get_max_volt_latency() Viresh Kumar
2017-01-23 4:41 ` [PATCH V2 12/12] PM / OPP: Update Documentation to remove RCU specific bits Viresh Kumar
[not found] ` <CGME20170123044228epcas3p35fdbe94a890062e9d66e33a3b5e4d571@epcas3p3.samsung.com>
2017-01-31 7:17 ` [PATCH V2 07/12] PM / OPP: Update OPP users to put reference MyungJoo Ham
2017-01-31 8:47 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131084724.GB7458@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=gnurou@gmail.com \
--cc=javi.merino@kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=khilman@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox