From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-pm@vger.kernel.org
Cc: edubezval@gmail.com, rui.zhang@intel.com, orjan.eide@arm.com,
lukasz.luba@arm.com, chris.diamand@arm.com,
javi.merino@kernel.org
Subject: [PATCH v2 1/3] thermal: devfreq_cooling: refactor code and add get_voltage function
Date: Tue, 31 Jan 2017 16:11:45 +0000 [thread overview]
Message-ID: <20170131161147.17002-2-lukasz.luba@arm.com> (raw)
In-Reply-To: <20170131161147.17002-1-lukasz.luba@arm.com>
Move the code which gets the voltage for a given frequency.
This code will be resused in another place.
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
drivers/thermal/devfreq_cooling.c | 43 ++++++++++++++++++++++++---------------
1 file changed, 27 insertions(+), 16 deletions(-)
diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c
index 5a737fd..7d55652 100644
--- a/drivers/thermal/devfreq_cooling.c
+++ b/drivers/thermal/devfreq_cooling.c
@@ -200,6 +200,31 @@ freq_get_state(struct devfreq_cooling_device *dfc, unsigned long freq)
return THERMAL_CSTATE_INVALID;
}
+static unsigned long get_voltage(struct devfreq *df, unsigned long freq)
+{
+ struct device *dev = df->dev.parent;
+ unsigned long voltage;
+ struct dev_pm_opp *opp;
+
+ rcu_read_lock();
+
+ opp = dev_pm_opp_find_freq_exact(dev, freq, true);
+ if (IS_ERR(opp) && (PTR_ERR(opp) == -ERANGE))
+ opp = dev_pm_opp_find_freq_exact(dev, freq, false);
+
+ voltage = dev_pm_opp_get_voltage(opp) / 1000; /* mV */
+
+ rcu_read_unlock();
+
+ if (voltage == 0) {
+ dev_warn_ratelimited(dev,
+ "Failed to get voltage for frequency %lu: %ld\n",
+ freq, IS_ERR(opp) ? PTR_ERR(opp) : 0);
+ }
+
+ return voltage;
+}
+
/**
* get_static_power() - calculate the static power
* @dfc: Pointer to devfreq cooling device
@@ -214,29 +239,15 @@ static unsigned long
get_static_power(struct devfreq_cooling_device *dfc, unsigned long freq)
{
struct devfreq *df = dfc->devfreq;
- struct device *dev = df->dev.parent;
unsigned long voltage;
- struct dev_pm_opp *opp;
if (!dfc->power_ops->get_static_power)
return 0;
- rcu_read_lock();
-
- opp = dev_pm_opp_find_freq_exact(dev, freq, true);
- if (IS_ERR(opp) && (PTR_ERR(opp) == -ERANGE))
- opp = dev_pm_opp_find_freq_exact(dev, freq, false);
+ voltage = get_voltage(df, freq);
- voltage = dev_pm_opp_get_voltage(opp) / 1000; /* mV */
-
- rcu_read_unlock();
-
- if (voltage == 0) {
- dev_warn_ratelimited(dev,
- "Failed to get voltage for frequency %lu: %ld\n",
- freq, IS_ERR(opp) ? PTR_ERR(opp) : 0);
+ if (voltage == 0)
return 0;
- }
return dfc->power_ops->get_static_power(df, voltage);
}
--
2.9.2
next prev parent reply other threads:[~2017-01-31 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 16:11 [PATCH v2 0/3] devfreq_cooling: let the driver supply the real power every time we need it Lukasz Luba
2017-01-31 16:11 ` Lukasz Luba [this message]
2017-01-31 16:11 ` [PATCH v2 2/3] thermal: devfreq_cooling: add new interface for direct power read Lukasz Luba
2017-02-21 13:34 ` Javi Merino
2017-01-31 16:11 ` [PATCH v2 3/3] trace: thermal: add another parameter *power to the tracing function Lukasz Luba
2017-02-21 13:35 ` [PATCH v2 0/3] devfreq_cooling: let the driver supply the real power every time we need it Javi Merino
2017-02-28 13:52 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131161147.17002-2-lukasz.luba@arm.com \
--to=lukasz.luba@arm.com \
--cc=chris.diamand@arm.com \
--cc=edubezval@gmail.com \
--cc=javi.merino@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=orjan.eide@arm.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox