From: Viresh Kumar <viresh.kumar@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Kukjin Kim" <kgene@kernel.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] cpufreq: s3c2416: double free on driver init error path
Date: Wed, 8 Feb 2017 08:54:21 +0530 [thread overview]
Message-ID: <20170208032421.GC14503@vireshk-i7> (raw)
In-Reply-To: <20170207131906.GD27416@mwanda>
On 07-02-17, 16:19, Dan Carpenter wrote:
> The "goto err_armclk;" error path already does a clk_put(s3c_freq->hclk);
> so this is a double free.
>
> Fixes: 34ee55075265 ("[CPUFREQ] Add S3C2416/S3C2450 cpufreq driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/cpufreq/s3c2416-cpufreq.c b/drivers/cpufreq/s3c2416-cpufreq.c
> index d6d425773fa4..5b2db3c6568f 100644
> --- a/drivers/cpufreq/s3c2416-cpufreq.c
> +++ b/drivers/cpufreq/s3c2416-cpufreq.c
> @@ -400,7 +400,6 @@ static int s3c2416_cpufreq_driver_init(struct cpufreq_policy *policy)
> rate = clk_get_rate(s3c_freq->hclk);
> if (rate < 133 * 1000 * 1000) {
> pr_err("cpufreq: HCLK not at 133MHz\n");
> - clk_put(s3c_freq->hclk);
> ret = -EINVAL;
> goto err_armclk;
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2017-02-08 3:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 13:19 [patch] cpufreq: s3c2416: double free on driver init error path Dan Carpenter
2017-02-07 20:29 ` Krzysztof Kozlowski
2017-02-08 3:24 ` Viresh Kumar [this message]
2017-02-09 12:44 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208032421.GC14503@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=heiko@sntech.de \
--cc=javier@osg.samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).