From: Chen Yu <yu.c.chen@intel.com>
To: linux-pm@vger.kernel.org
Cc: inux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Zhang Rui <rui.zhang@intel.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 1/2][RFC v3] ACPI throttling: Disable the MSR T-state if enabled after resumed
Date: Mon, 13 Feb 2017 10:17:55 +0800 [thread overview]
Message-ID: <20170213021755.GA22608@yu-desktop-1.sh.intel.com> (raw)
In-Reply-To: <1fd9d91c7cbdd314ebb6e65264f57f430dfb89ca.1486483294.git.yu.c.chen@intel.com>
On Wed, Feb 08, 2017 at 12:23:16AM +0800, Chen Yu wrote:
> Previously a bug was reported that on certain Broadwell
> platform, after resumed from S3, the CPU is running at
> an anomalously low speed, due to the BIOS has enabled the
> MSR throttling across S3. The solution to this was to introduce
> a quirk framework to save/restore tstate MSR register around
> suspend/resume, in Commit 7a9c2dd08ead ("x86/pm:
> Introduce quirk framework to save/restore extra MSR
> registers around suspend/resume").
>
> There are three problems here:
> 1. More and more reports show that other platforms also
> encountered the same issue, so the quirk list might
> be endless.
> 2. Each CPUs should take the save/restore operation into
> consideration, rather than the nonboot CPU alone.
> 3. Normally ACPI T-state re-evaluation is done on resume,
> however there is no _TSS on the bogus platform, thus
> above re-evaluation code does not run on that machine.
>
> Solution:
> This patch is based on the fact that, we generally should not
> expect the system to come back from resume with throttling
> enabled, but leverage the OS components to deal with it,
> such as thermal event. So we simply clear the MSR T-state
> and print the warning if it is found to be enabled after
> resumed back.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=90041
> Reported-by: Kadir <kadir@colakoglu.nl>
> Suggested-by: Len Brown <lenb@kernel.org>
> Cc: Len Brown <lenb@kernel.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> ---
Please ignore this patch for now, need to do more test on this.
Thanks,
Yu
next prev parent reply other threads:[~2017-02-13 2:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 16:15 [PATCH 0/2] Disable the MSR T-state if it is enabled after resumed Chen Yu
2017-02-07 16:23 ` [PATCH 1/2][RFC v3] ACPI throttling: Disable the MSR T-state if " Chen Yu
2017-02-07 16:55 ` Yu Chen
2017-02-13 2:17 ` Chen Yu [this message]
2017-02-07 16:25 ` [PATCH 2/2][RFC v3] x86/pm: Delete the quirk to save/restore extra MSR around suspend/resume Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213021755.GA22608@yu-desktop-1.sh.intel.com \
--to=yu.c.chen@intel.com \
--cc=inux-kernel@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).