* [PATCH v1] power: supply: bq25890: Use gpiod_get()
@ 2017-02-20 17:12 Andy Shevchenko
2017-02-28 15:13 ` Andy Shevchenko
2017-03-15 21:18 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2017-02-20 17:12 UTC (permalink / raw)
To: Sebastian Reichel, linux-pm; +Cc: Andy Shevchenko
Since index is always 0, replace gpiod_get_index() by gpiod_get().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/power/supply/bq25890_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c
index f993a55cde20..8e2c41ded171 100644
--- a/drivers/power/supply/bq25890_charger.c
+++ b/drivers/power/supply/bq25890_charger.c
@@ -723,7 +723,7 @@ static int bq25890_irq_probe(struct bq25890_device *bq)
{
struct gpio_desc *irq;
- irq = devm_gpiod_get_index(bq->dev, BQ25890_IRQ_PIN, 0, GPIOD_IN);
+ irq = devm_gpiod_get(bq->dev, BQ25890_IRQ_PIN, GPIOD_IN);
if (IS_ERR(irq)) {
dev_err(bq->dev, "Could not probe irq pin.\n");
return PTR_ERR(irq);
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] power: supply: bq25890: Use gpiod_get()
2017-02-20 17:12 [PATCH v1] power: supply: bq25890: Use gpiod_get() Andy Shevchenko
@ 2017-02-28 15:13 ` Andy Shevchenko
2017-03-15 21:18 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2017-02-28 15:13 UTC (permalink / raw)
To: Sebastian Reichel, linux-pm
On Mon, 2017-02-20 at 19:12 +0200, Andy Shevchenko wrote:
> Since index is always 0, replace gpiod_get_index() by gpiod_get().
>
Any comments on this?
I would reduce as much as possible use of gpiod_get_index*() to sort out
things later.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/power/supply/bq25890_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq25890_charger.c
> b/drivers/power/supply/bq25890_charger.c
> index f993a55cde20..8e2c41ded171 100644
> --- a/drivers/power/supply/bq25890_charger.c
> +++ b/drivers/power/supply/bq25890_charger.c
> @@ -723,7 +723,7 @@ static int bq25890_irq_probe(struct bq25890_device
> *bq)
> {
> struct gpio_desc *irq;
>
> - irq = devm_gpiod_get_index(bq->dev, BQ25890_IRQ_PIN, 0,
> GPIOD_IN);
> + irq = devm_gpiod_get(bq->dev, BQ25890_IRQ_PIN, GPIOD_IN);
> if (IS_ERR(irq)) {
> dev_err(bq->dev, "Could not probe irq pin.\n");
> return PTR_ERR(irq);
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] power: supply: bq25890: Use gpiod_get()
2017-02-20 17:12 [PATCH v1] power: supply: bq25890: Use gpiod_get() Andy Shevchenko
2017-02-28 15:13 ` Andy Shevchenko
@ 2017-03-15 21:18 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2017-03-15 21:18 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-pm
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
Hi,
On Mon, Feb 20, 2017 at 07:12:23PM +0200, Andy Shevchenko wrote:
> Since index is always 0, replace gpiod_get_index() by gpiod_get().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/power/supply/bq25890_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c
> index f993a55cde20..8e2c41ded171 100644
> --- a/drivers/power/supply/bq25890_charger.c
> +++ b/drivers/power/supply/bq25890_charger.c
> @@ -723,7 +723,7 @@ static int bq25890_irq_probe(struct bq25890_device *bq)
> {
> struct gpio_desc *irq;
>
> - irq = devm_gpiod_get_index(bq->dev, BQ25890_IRQ_PIN, 0, GPIOD_IN);
> + irq = devm_gpiod_get(bq->dev, BQ25890_IRQ_PIN, GPIOD_IN);
> if (IS_ERR(irq)) {
> dev_err(bq->dev, "Could not probe irq pin.\n");
> return PTR_ERR(irq);
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-15 21:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-20 17:12 [PATCH v1] power: supply: bq25890: Use gpiod_get() Andy Shevchenko
2017-02-28 15:13 ` Andy Shevchenko
2017-03-15 21:18 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).