From: Juri Lelli <juri.lelli@arm.com>
To: Joel Fernandes <joelaf@google.com>
Cc: Patrick Bellasi <patrick.bellasi@arm.com>,
"Joel Fernandes (Google)" <joel.opensrc@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Andres Oportus <andresoportus@google.com>
Subject: Re: [RFC v3 5/5] sched/{core,cpufreq_schedutil}: add capacity clamping for RT/DL tasks
Date: Thu, 16 Mar 2017 11:16:44 +0000 [thread overview]
Message-ID: <20170316111644.GP31499@e106622-lin> (raw)
In-Reply-To: <CAJWu+ooCmyx7PNXhzrDsUQM=eU1zxo8F3gyp2ihpabpREk5vfg@mail.gmail.com>
On 15/03/17 16:40, Joel Fernandes wrote:
> On Wed, Mar 15, 2017 at 9:24 AM, Juri Lelli <juri.lelli@arm.com> wrote:
> [..]
> >
> >> > However, trying to quickly summarize how that would work (for who is
> >> > already somewhat familiar with reclaiming bits):
> >> >
> >> > - a task utilization contribution is accounted for (at rq level) as
> >> > soon as it wakes up for the first time in a new period
> >> > - its contribution is then removed after the 0lag time (or when the
> >> > task gets throttled)
> >> > - frequency transitions are triggered accordingly
> >> >
> >> > So, I don't see why triggering a go down request after the 0lag time
> >> > expired and quickly reacting to tasks waking up would have create
> >> > problems in your case?
> >>
> >> In my experience, the 'reacting to tasks' bit doesn't work very well.
> >
> > Humm.. but in this case we won't be 'reacting', we will be
> > 'anticipating' tasks' needs, right?
>
> Are you saying we will start ramping frequency before the next
> activation so that we're ready for it?
>
I'm saying that there is no need to ramp, simply select the frequency
that is needed for a task (or a set of them).
> If not, it sounds like it will only make the frequency request on the
> next activation when the Active bandwidth increases due to the task
> waking up. By then task has already started to run, right?
>
When the task is enqueued back we select the frequency considering its
bandwidth request (and the bandwidth/utilization of the others). So,
when it actually starts running it will already have enough capacity to
finish in time.
next prev parent reply other threads:[~2017-03-16 11:16 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 14:38 [RFC v3 0/5] Add capacity capping support to the CPU controller Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 1/5] sched/core: add capacity constraints to " Patrick Bellasi
2017-03-13 10:46 ` Joel Fernandes (Google)
2017-03-15 11:20 ` Patrick Bellasi
2017-03-15 13:20 ` Joel Fernandes
2017-03-15 16:10 ` Paul E. McKenney
2017-03-15 16:44 ` Patrick Bellasi
2017-03-15 17:24 ` Paul E. McKenney
2017-03-15 17:57 ` Patrick Bellasi
2017-03-20 17:15 ` Tejun Heo
2017-03-20 17:36 ` Tejun Heo
2017-03-20 18:08 ` Patrick Bellasi
2017-03-23 0:28 ` Joel Fernandes (Google)
2017-03-23 10:32 ` Patrick Bellasi
2017-03-23 16:01 ` Tejun Heo
2017-03-23 18:15 ` Patrick Bellasi
2017-03-23 18:39 ` Tejun Heo
2017-03-24 6:37 ` Joel Fernandes (Google)
2017-03-24 15:00 ` Tejun Heo
2017-03-30 21:13 ` Paul Turner
2017-03-24 7:02 ` Joel Fernandes (Google)
2017-03-30 21:15 ` Paul Turner
2017-04-01 16:25 ` Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 2/5] sched/core: track CPU's capacity_{min,max} Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 3/5] sched/core: sync capacity_{min,max} between slow and fast paths Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 4/5] sched/{core,cpufreq_schedutil}: add capacity clamping for FAIR tasks Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 5/5] sched/{core,cpufreq_schedutil}: add capacity clamping for RT/DL tasks Patrick Bellasi
2017-03-13 10:08 ` Joel Fernandes (Google)
2017-03-15 11:40 ` Patrick Bellasi
2017-03-15 12:59 ` Joel Fernandes
2017-03-15 14:44 ` Juri Lelli
2017-03-15 16:13 ` Joel Fernandes
2017-03-15 16:24 ` Juri Lelli
2017-03-15 23:40 ` Joel Fernandes
2017-03-16 11:16 ` Juri Lelli [this message]
2017-03-16 12:27 ` Patrick Bellasi
2017-03-16 12:44 ` Juri Lelli
2017-03-16 16:58 ` Joel Fernandes
2017-03-16 17:17 ` Juri Lelli
2017-03-15 11:41 ` [RFC v3 0/5] Add capacity capping support to the CPU controller Rafael J. Wysocki
2017-03-15 12:59 ` Patrick Bellasi
2017-03-16 1:04 ` Rafael J. Wysocki
2017-03-16 3:15 ` Joel Fernandes
2017-03-20 22:51 ` Rafael J. Wysocki
2017-03-21 11:01 ` Patrick Bellasi
2017-03-24 23:52 ` Rafael J. Wysocki
2017-03-16 12:23 ` Patrick Bellasi
2017-03-20 14:51 ` Tejun Heo
2017-03-20 17:22 ` Patrick Bellasi
2017-04-10 7:36 ` Peter Zijlstra
2017-04-11 17:58 ` Patrick Bellasi
2017-04-12 12:10 ` Peter Zijlstra
2017-04-12 13:55 ` Patrick Bellasi
2017-04-12 15:37 ` Peter Zijlstra
2017-04-13 11:33 ` Patrick Bellasi
2017-04-12 12:15 ` Peter Zijlstra
2017-04-12 13:34 ` Patrick Bellasi
2017-04-12 14:41 ` Peter Zijlstra
2017-04-12 12:22 ` Peter Zijlstra
2017-04-12 13:24 ` Patrick Bellasi
2017-04-12 12:48 ` Peter Zijlstra
2017-04-12 13:27 ` Patrick Bellasi
2017-04-12 14:34 ` Peter Zijlstra
2017-04-12 14:43 ` Patrick Bellasi
2017-04-12 16:14 ` Peter Zijlstra
2017-04-13 10:34 ` Patrick Bellasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316111644.GP31499@e106622-lin \
--to=juri.lelli@arm.com \
--cc=andresoportus@google.com \
--cc=joel.opensrc@gmail.com \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).