Re: [PATCH 01/15] mfd: Add Cherry Trail Whiskey Cove PMIC driver

Lee Jones
2017-03-20T10:41:52Z

On Fri, 17 Mar 2017, Andy Shevchenko wrote:

> On Fri, 2017-03-17 at 10:55 +0100, Hans de Goede wrote:
> > Add mfd driver for Intel CHT Whiskey Cove PMIC, based on various non
> > upstreamed CHT Whiskey Cove PMIC patches.
> >
> > This is a somewhat minimal version which adds irqchip support and
> > cells
> > for: ACPI PMIC opregion support, the i2c-controller driving the
> > external
> > charger irc and the pwrsrc/extcon block.
> >
> > Further cells can be added in the future if/when drivers are
> > upstreamed
> > for them.
>
> Couple of minor comments, otherwise looks good to me:
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> > +/* Whiskey Cove PMIC share same ACPI ID between different platforms
> > */
> > +#define CHT_WC_HRV 3
> > +
> > +/* Level 1 IRQs (level 2 IRQs are handled in the child device
> > drivers) */
> > +enum {
> > + CHT_WC_PWRSRC_IRQ = 0,
> > + CHT_WC_THRM_IRQ,
> > + CHT_WC_BCU_IRQ,
> > + CHT_WC_ADC_IRQ,
> > + CHT_WC_EXT_CHGR_IRQ,
> > + CHT_WC_GPIO_IRQ,
> > + /* There is no irq 6 */
> > + CHT_WC_CRIT_IRQ = 7,
>
> I would prefer explicit over implicit (adding = N to each line), but
> this is minor.

No need. The C standard is clear on what is expected of enums.

[...]

> > + return devm_mfd_add_devices(dev, -1, cht_wc_dev,
> > ARRAY_SIZE(cht_wc_dev),
> > + NULL, 0, regmap_irq_get_domain(pmic-
> > >irq_chip_data));
>
> PLATFORM_DEVID_NONE, please.

+1

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog