Re: [04/15] power: supply: bq24190_charger: Add no_register_reset pdata flag

Andy Shevchenko
2017-03-19T15:00:48Z

On Sat, 2017-03-18 at 17:57 -0700, Liam Breck wrote:

>> Assuming the platform_data has sane values like uA that means
> > re-implementing most of the bq24190 driver in the code filling
> > the platform data (to go from register values to uA) that does
> > not seem like a sane approach when a simple do not reset
> > flag suffices. Note also see below for another way to deal
> > with this.
>
> I am suggesting you treat platform_data like a DT node: fill it with
> board-specific params. Don't compute the params, read them manually
> via /sys/class/...-charger/f_* and hard-code them for this board. That
> gives you control over the charger config. You've already found that
> you need that given the high voltage setting.

Guys, did you see my mail regarding all these?

Repeating myself here:

"I would not extend platform data at all.
For GPIO we may use GPIO lookup tables, for the rest -- unified (built-
in) device properties API.

Consider to get rid of
include/linux/power/bq24190_charger.h
completely."

Do you consider that approach? If no, why not?

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy