From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Sebastian Reichel <sre@kernel.org>,
Liam Breck <liam@networkimprov.net>,
Mark Greer <mgreer@animalcreek.com>,
Colin Ian King <colin.king@canonical.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: bq24190_charger: mark PM functions as __maybe_unused
Date: Mon, 20 Mar 2017 07:33:09 -0700 [thread overview]
Message-ID: <20170320143309.GF20572@atomide.com> (raw)
In-Reply-To: <20170320131424.271241-1-arnd@arndb.de>
* Arnd Bergmann <arnd@arndb.de> [170320 06:17]:
> Without CONFIG_PM, we get a harmless warning:
>
> drivers/power/supply/bq24190_charger.c:1514:12: error: 'bq24190_runtime_resume' defined but not used [-Werror=unused-function]
> drivers/power/supply/bq24190_charger.c:1501:12: error: 'bq24190_runtime_suspend' defined but not used [-Werror=unused-function]
>
> To avoid the warning, we can mark all four PM functions as __maybe_unused,
> which also lets us remove the incorrect #ifdef.
>
> Fixes: 3d8090cba638 ("power: bq24190_charger: Check the interrupt status on resume")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for fixing that:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2017-03-20 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 13:14 [PATCH] power: bq24190_charger: mark PM functions as __maybe_unused Arnd Bergmann
2017-03-20 14:33 ` Tony Lindgren [this message]
2017-03-20 18:29 ` Liam Breck
2017-03-20 21:39 ` Sebastian Reichel
2017-03-21 3:55 ` Mark Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320143309.GF20572@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=colin.king@canonical.com \
--cc=liam@networkimprov.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).