Re: [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions

Ingo Molnar
2017-04-12T06:52:15Z

* Jiri Slaby <jslaby@suse.cz> wrote:

> On 04/10/2017, 09:35 PM, Josh Poimboeuf wrote:
> > The code should be in a mergeable state after each patch. If only
> > patches 1-3 were merged, the code would be in an inconsistent state,
> > with some functions having confusing ENTRY/SYM_FUNC_END pairs. That
> > complicates git history and also makes it harder to review each patch.
> >
> > It would be cleaner to separate things out. First, convert ENTRY/END
> > functions to use ENDPROC, which is a minor bug fix. Then they can be
> > converted to the new SYM_FUNC_START/END macros in a separate patch.
>
> OTOH I don't think touching and reviewing the same place twice is what
> actually maintainers would want to see. But as I wrote earlier, I can do
> whatever is preferred -- therefore I am asking before I start reworking
> the patches: maintainers, what do you prefer?

I'd lean towards Josh's suggestion of a more granular series. Having to review
more is sometimes less, if the patches are more focused.

Thanks,

Ingo