Re: [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data

Thomas Gleixner
2017-03-01T10:09:45Z

On Wed, 1 Mar 2017, Ingo Molnar wrote:
>
> * Jiri Slaby <jslaby@suse.cz> wrote:
>
> > This is a start of series to unify use of ENTRY, ENDPROC, GLOBAL, END,
> > and other macros across x86. When we have all this sorted out, this will
> > help to inject DWARF unwinding info by objtool later.
> >
> > So, let us use the macros this way:
> > * ENTRY -- start of a global function
> > * ENDPROC -- end of a local/global function
> > * GLOBAL -- start of a globally visible data symbol
> > * END -- end of local/global data symbol
>
> So how about using macro names that actually show the purpose, instead of
> importing all the crappy, historic, essentially randomly chosen debug symbol macro
> names from the binutils and older kernels?
>
> Something sane, like:
>
> SYM__FUNCTION_START

Sane would be:

SYM_FUNCTION_START

The double underscore is just not giving any value.

Thanks,

tglx