Re: [PATCH v2 02/10] x86: assembly, FUNC_START for fn, DATA_START for data

Pavel Machek
2017-03-21T14:08:41Z

[-- Attachment #1.1: Type: text/plain, Size: 660 bytes --]

Hi!

> -ENTRY(saved_rbp) .quad 0
> -ENTRY(saved_rsi) .quad 0
> -ENTRY(saved_rdi) .quad 0
> -ENTRY(saved_rbx) .quad 0
> +SYM_DATA_START(saved_rbp) .quad 0
> +SYM_DATA_START(saved_rsi) .quad 0
> +SYM_DATA_START(saved_rdi) .quad 0
> +SYM_DATA_START(saved_rbx) .quad 0

Does it make sense to call it SYM_DATA_*START* when there's no
corresponding end?

Plus... it looks like saved_rsi (and friends) are only used inside
wakeup_64.S. Could we just delete the "ENTRY" annotations?

Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org