From: Tony Lindgren <tony@atomide.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Sebastian Reichel <sre@kernel.org>, Takashi Iwai <tiwai@suse.de>,
linux-pm@vger.kernel.org, Liam Breck <kernel@networkimprov.net>
Subject: Re: [PATCH v2 6/7] power: supply: bq24190_charger: Cleanup error-exit labels in probe()
Date: Wed, 22 Mar 2017 08:45:04 -0700 [thread overview]
Message-ID: <20170322154503.GW8575@atomide.com> (raw)
In-Reply-To: <20170322145536.30570-7-hdegoede@redhat.com>
* Hans de Goede <hdegoede@redhat.com> [170322 07:57]:
> Names like out1, out2, etc. do not make it easier to follow what is
> going on and make it harder (require renaming) if any steps are
> later added / removed. Rename the labels to sane names.
>
> This also folds out1 and out2 into one pm_runtime_disable step,
> if pm_runtime_get_sync fails we still need to do the put, it
> failing means that the device failed to resume, but the refcount
> will have been incremented and we need to decrement it.
Seems OK to me:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2017-03-22 15:54 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 14:55 [PATCH 0/7] power: supply: bq24190_charger: Various fixes + extcon support Hans de Goede
2017-03-22 14:55 ` [PATCH v2 1/7] power: supply: bq24190_charger: Use i2c-core irq-mapping code Hans de Goede
2017-03-22 15:37 ` Tony Lindgren
2017-03-23 11:11 ` Sebastian Reichel
2017-03-24 23:44 ` Liam Breck
2017-03-22 14:55 ` [PATCH v2 2/7] power: supply: bq24190_charger: Add support for bq24192i Hans de Goede
2017-03-23 11:12 ` Sebastian Reichel
2017-03-24 23:34 ` Liam Breck
2017-03-22 14:55 ` [PATCH v2 3/7] power: supply: bq24190_charger: Use extcon to determine ilimit, 5v boost Hans de Goede
2017-03-22 15:50 ` Tony Lindgren
2017-03-22 15:57 ` Hans de Goede
2017-03-22 18:50 ` Liam Breck
2017-03-23 8:31 ` Hans de Goede
2017-03-22 14:55 ` [PATCH v2 4/7] power: supply: bq24190_charger: Never reset the charger chip Hans de Goede
2017-03-22 15:43 ` Tony Lindgren
2017-03-22 15:45 ` Hans de Goede
2017-03-22 15:51 ` Tony Lindgren
2017-03-23 7:16 ` Liam Breck
2017-03-23 8:44 ` Hans de Goede
2017-03-23 11:36 ` Liam Breck
2017-03-23 11:44 ` Hans de Goede
2017-03-23 11:47 ` Liam Breck
2017-03-23 11:48 ` Hans de Goede
2017-03-23 20:33 ` Liam Breck
2017-03-23 22:01 ` Hans de Goede
2017-03-24 23:49 ` Liam Breck
2017-03-22 18:41 ` Liam Breck
2017-03-23 8:16 ` Hans de Goede
2017-03-23 10:59 ` Sebastian Reichel
2017-03-23 11:20 ` Sebastian Reichel
2017-03-22 14:55 ` [PATCH v2 5/7] power: supply: bq24190_charger: Don't spam the logs on charger plug / unplug Hans de Goede
2017-03-22 15:44 ` Tony Lindgren
2017-03-23 11:17 ` Sebastian Reichel
2017-03-23 13:34 ` Liam Breck
2017-03-23 21:31 ` Liam Breck
2017-03-23 22:02 ` Hans de Goede
2017-03-23 22:24 ` Liam Breck
2017-03-24 9:25 ` Sebastian Reichel
2017-03-24 23:31 ` Liam Breck
2017-03-24 10:29 ` [PATCH] power: bq24190_charger: Limit over/under voltage fault logging Liam Breck
2017-03-25 11:17 ` Hans de Goede
2017-03-25 11:24 ` [PATCH v2] " Liam Breck
2017-03-26 8:44 ` Hans de Goede
2017-03-26 10:56 ` Liam Breck
2017-03-26 11:04 ` Hans de Goede
2017-03-29 16:33 ` Tony Lindgren
2017-03-22 14:55 ` [PATCH v2 6/7] power: supply: bq24190_charger: Cleanup error-exit labels in probe() Hans de Goede
2017-03-22 15:45 ` Tony Lindgren [this message]
2017-03-22 19:09 ` Liam Breck
2017-03-23 8:37 ` Hans de Goede
2017-03-24 23:58 ` Liam Breck
2017-03-23 11:21 ` Sebastian Reichel
2017-03-23 11:46 ` Hans de Goede
2017-03-22 14:55 ` [PATCH v2 7/7] power: supply: bq24190_charger: Remove battery power_supply device Hans de Goede
2017-03-25 0:19 ` Liam Breck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322154503.GW8575@atomide.com \
--to=tony@atomide.com \
--cc=hdegoede@redhat.com \
--cc=kernel@networkimprov.net \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).