Re: [PATCH v2 2/7] power: supply: bq24190_charger: Add support for bq24192i

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

Hi,

On Wed, Mar 22, 2017 at 03:55:31PM +0100, Hans de Goede wrote:
> The bq24192 and bq24192i are mostly identical to the bq24190, TI even
> published a single datasheet for all 3 of them. The difference
> between the bq24190 and bq24192[i] is the way charger-type detection
> is done, the bq24190 is to be directly connected to the USB a/b lines,
> where as the the bq24192[i] has a gpio which should be driven high/low
> externally depending on the type of charger connected, from a register
> level access pov there is no difference.
> 
> The differences between the bq24192 and bq24192i are:
> 1) Lower default charge rate on the bq24192i
> 2) Pre-charge-current can be max 640 mA on the bq24192i
> 
> On x86/ACPI systems the code which instantiates the i2c client may not
> know the exact variant being used, so instead of coding the model-id
> in the i2c_id struct and bailing if it does not match, check the reported
> model-id matches one of the supported variants.
> 
> This commit only adds support for the bq24192i as I don't
> have a bq24192 to test with, adding support for the bq24192 should
> be as simple as also accepting its model-id in the model-id test.
> 
> Cc: Liam Breck <kernel@networkimprov.net>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> -Improve commit msg
> -Drop model-id from bq24190_i2c_ids table and bdi struct
> -Only add support for the bq24192i and not for the bq24192
> ---

Thanks, queued.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]