Re: [PATCH v1 7/7] power: bq24190_charger: Set bq24190-battery device .type=unknown

Hans de Goede
2017-03-22T14:50:17Z

Hi,

On 22-03-17 14:37, Liam Breck wrote:
> On Wed, Mar 22, 2017 at 6:15 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>> Hi,
>>
>> On 22-03-17 13:25, Hans de Goede wrote:
>>>
>>> Hi,
>>>
>>> On 21-03-17 23:09, Liam Breck wrote:
>>>>
>>>> From: Liam Breck <kernel@networkimprov.net>
>>>>
>>>> Not for upstream. Temporary workaround to prevent bq24190-battery device
>>>> from interfering with a fuel gauge that has
>>>> .type=power_supply_type_battery
>>>>
>>>> I'll move properties from -battery device to -charger in a subsequent
>>>> version.
>>>>
>>>> Cc: Hans de Goede <hdegoede@redhat.com>
>>>
>>>
>>> Hmm, I don't like this. I was about to post v2 of my patches (which I will
>>> rebase on top of this series)
>>
>>
>> It seems this series does not apply to:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next
>>
>> It looks like there is another series which sits in between ?
>
> Yes, see two patches linked in Depends-on lines. Could you add those and rebase?

I can confirm that with those 2 patches thrown in things apply
cleanly on linux-power-supply/for-next.

I see that these 2 patches add a new devicetree binding for describing
a battery. That is really cool stuff and long overdue IMHO I'm glad
to see someone doing this.

But (sorry) in my experience getting new devicetree bindings upstream
often takes a while, while people are discussing the best way to
solve things. So I'm not quite sure this will go upstream real soon
now and I would like to get my patches into -next in time for 4.12
if possible.

So for now I'm going to hold of on rebasing and just send v2 as is
(based on linux-power-supply/for-next). If Sebastian thinks your
patches should go first I will happily do a rebased v3.

Regards,

Hans