From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Breck Subject: [PATCH v2] power: bq24190_charger: Limit over/under voltage fault logging Date: Sat, 25 Mar 2017 04:24:19 -0700 Message-ID: <20170325112419.25120-1-liam@networkimprov.net> References: <20170322145536.30570-6-hdegoede@redhat.com> Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:33565 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbdCYLZD (ORCPT ); Sat, 25 Mar 2017 07:25:03 -0400 Received: by mail-pg0-f67.google.com with SMTP id 79so2592867pgf.0 for ; Sat, 25 Mar 2017 04:24:46 -0700 (PDT) In-Reply-To: <20170322145536.30570-6-hdegoede@redhat.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Sebastian Reichel Cc: linux-pm@vger.kernel.org, Tony Lindgren , Hans de Goede , Liam Breck From: Liam Breck If the charger is unplugged before the battery is full we may see an over/under voltage fault. Ignore this rather then emitting a message or uevent. This fixes messages like these getting logged on charger unplug + replug: bq24190-charger 15-006b: Fault: boost 0, charge 1, battery 0, ntc 0 bq24190-charger 15-006b: Fault: boost 0, charge 0, battery 0, ntc 0 Cc: Tony Lindgren Cc: Hans de Goede Signed-off-by: Liam Breck --- v2: Don't hide clearance of other more urgent faults, or produce a uevent for this superficial fault. drivers/power/supply/bq24190_charger.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c index 897491d..de1c54f 100644 --- a/drivers/power/supply/bq24190_charger.c +++ b/drivers/power/supply/bq24190_charger.c @@ -1256,8 +1256,13 @@ static void bq24190_check_status(struct bq24190_dev_info *bdi) } } while (f_reg && ++i < 2); + /* ignore over/under voltage fault after disconnect */ + if (f_reg == (1 << BQ24190_REG_F_CHRG_FAULT_SHIFT) && + !(ss_reg & BQ24190_REG_SS_PG_STAT_MASK)) + f_reg = 0; + if (f_reg != bdi->f_reg) { - dev_info(bdi->dev, + dev_warn(bdi->dev, "Fault: boost %d, charge %d, battery %d, ntc %d\n", !!(f_reg & BQ24190_REG_F_BOOST_FAULT_MASK), !!(f_reg & BQ24190_REG_F_CHRG_FAULT_MASK), -- 2.9.3