From: Tony Lindgren <tony@atomide.com>
To: Johan Hovold <johan@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Alan Stern <stern@rowland.harvard.edu>,
Kevin Hilman <khilman@baylibre.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PM / Runtime: fix autosuspend documentation
Date: Mon, 10 Apr 2017 09:35:05 -0700 [thread overview]
Message-ID: <20170410163504.GF5339@atomide.com> (raw)
In-Reply-To: <20170410113825.17399-1-johan@kernel.org>
* Johan Hovold <johan@kernel.org> [170410 04:41]:
> Update the autosuspend documentation which claimed that the autosuspend
> delay is not taken into account when using the non-autosuspend helper
> functions, something which is no longer true since commit d66e6db28df3
> ("PM / Runtime: Respect autosuspend when idle triggers suspend").
>
> This specifically means that drivers must now disable autosuspend before
> disabling runtime pm in probe error paths and remove callbacks if
> pm_runtime_put_sync was being used to suspend the device before
> returning. (If an idle callback can prevent suspend,
> pm_runtime_put_sync_suspend must be used instead of pm_runtime_put_sync
> as before.)
>
> Also remove the claim that the autosuspend helpers behave "just like
> the non-autosuspend counterparts", something which have never really
> been true as some of the latter use idle notifications.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2017-04-10 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 11:38 [PATCH 1/2] PM / Runtime: fix autosuspend documentation Johan Hovold
2017-04-10 11:38 ` [PATCH 2/2] PM / Runtime: document autosuspend-helper side effects Johan Hovold
2017-04-10 16:36 ` Tony Lindgren
2017-04-10 16:35 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410163504.GF5339@atomide.com \
--to=tony@atomide.com \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).