From: Liam Breck <liam@networkimprov.net>
To: Sebastian Reichel <sre@kernel.org>, linux-pm@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>,
Hans de Goede <hdegoede@redhat.com>,
Liam Breck <kernel@networkimprov.net>
Subject: [PATCH v5 4/4] power: bq24190_charger: Longer delay while polling reset flag
Date: Tue, 11 Apr 2017 04:59:57 -0700 [thread overview]
Message-ID: <20170411115957.14253-5-liam@networkimprov.net> (raw)
In-Reply-To: <20170411115957.14253-1-liam@networkimprov.net>
From: Liam Breck <kernel@networkimprov.net>
On chip reset, polling loop used udelay(10) which is too short
to be useful. Instead, use usleep_range(100, 200).
Cc: Tony Lindgren <tony@atomide.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Liam Breck <kernel@networkimprov.net>
---
drivers/power/supply/bq24190_charger.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
index a904abb..f581042 100644
--- a/drivers/power/supply/bq24190_charger.c
+++ b/drivers/power/supply/bq24190_charger.c
@@ -550,16 +550,13 @@ static int bq24190_register_reset(struct bq24190_dev_info *bdi)
if (ret < 0)
return ret;
+ if (v == 0)
+ return 0;
- if (!v)
- break;
- udelay(10);
+ usleep_range(100, 200);
} while (--limit);
- if (!limit)
- return -EIO;
-
- return 0;
+ return -EIO;
}
/* Charger power supply property routines */
--
2.9.3
next prev parent reply other threads:[~2017-04-11 12:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 11:59 [PATCH v5 0/4] BQ24190 charger fixes Liam Breck
2017-04-11 11:59 ` [PATCH v5 1/4] power: bq24190_charger: Limit over/under voltage fault logging Liam Breck
2017-04-11 11:59 ` [PATCH v5 2/4] power: bq24190_charger: Clean up extcon code Liam Breck
2017-04-11 11:59 ` [PATCH v5 3/4] power: bq24190_charger: Uniform pm_runtime_get() failure handling Liam Breck
2017-04-11 11:59 ` Liam Breck [this message]
2017-04-11 15:33 ` [PATCH v5 4/4] power: bq24190_charger: Longer delay while polling reset flag Tony Lindgren
2017-04-12 6:50 ` [PATCH v5 0/4] BQ24190 charger fixes Hans de Goede
2017-04-12 14:52 ` Sebastian Reichel
2017-04-20 5:12 ` Liam Breck
2017-05-11 4:52 ` Liam Breck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411115957.14253-5-liam@networkimprov.net \
--to=liam@networkimprov.net \
--cc=hdegoede@redhat.com \
--cc=kernel@networkimprov.net \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).