From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Breck Subject: [PATCH v5 4/4] power: bq24190_charger: Longer delay while polling reset flag Date: Tue, 11 Apr 2017 04:59:57 -0700 Message-ID: <20170411115957.14253-5-liam@networkimprov.net> References: <20170411115957.14253-1-liam@networkimprov.net> Return-path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:35061 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754551AbdDKMAE (ORCPT ); Tue, 11 Apr 2017 08:00:04 -0400 Received: by mail-pg0-f68.google.com with SMTP id g2so29557929pge.2 for ; Tue, 11 Apr 2017 05:00:04 -0700 (PDT) In-Reply-To: <20170411115957.14253-1-liam@networkimprov.net> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Sebastian Reichel , linux-pm@vger.kernel.org Cc: Tony Lindgren , Hans de Goede , Liam Breck From: Liam Breck On chip reset, polling loop used udelay(10) which is too short to be useful. Instead, use usleep_range(100, 200). Cc: Tony Lindgren Cc: Hans de Goede Signed-off-by: Liam Breck --- drivers/power/supply/bq24190_charger.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c index a904abb..f581042 100644 --- a/drivers/power/supply/bq24190_charger.c +++ b/drivers/power/supply/bq24190_charger.c @@ -550,16 +550,13 @@ static int bq24190_register_reset(struct bq24190_dev_info *bdi) if (ret < 0) return ret; + if (v == 0) + return 0; - if (!v) - break; - udelay(10); + usleep_range(100, 200); } while (--limit); - if (!limit) - return -EIO; - - return 0; + return -EIO; } /* Charger power supply property routines */ -- 2.9.3