From: Sebastian Reichel <sre@kernel.org>
To: Andi Shyti <andi.shyti@gmail.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Jiri Kosina <trivial@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Shyti <andi@etezian.org>,
Andi Shyti <andi.shyti@samsung.com>
Subject: Re: [PATCH] power: supply: charger manager: refactor return statements
Date: Tue, 11 Apr 2017 16:28:29 +0200 [thread overview]
Message-ID: <20170411142829.ymplbmjbqswqxin5@earth> (raw)
In-Reply-To: <20170329151357.1841-1-andi@etezian.org>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
Hi,
On Thu, Mar 30, 2017 at 12:13:57AM +0900, Andi Shyti wrote:
> Some trivial improvements on the returning value of the
> functions:
>
> - remove unnecessary goto labels that just return, return
> immediately, instead.
>
> - do not initialize when not needed.
>
> - return the value from the calling function that fails instead
> of politically choosing -EINVAL.
>
> Signed-off-by: Andi Shyti <andi@etezian.org>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-04-11 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 15:13 [PATCH] power: supply: charger manager: refactor return statements Andi Shyti
2017-04-11 14:28 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411142829.ymplbmjbqswqxin5@earth \
--to=sre@kernel.org \
--cc=andi.shyti@gmail.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox