Linux Power Management development
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: David Lechner <david@lechnology.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: sysfs: parse string as enum when writing property
Date: Tue, 11 Apr 2017 18:12:22 +0200	[thread overview]
Message-ID: <20170411161222.t23gsn4pvxofhnrh@earth> (raw)
In-Reply-To: <1491249177-8945-1-git-send-email-david@lechnology.com>

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

Hi,

On Mon, Apr 03, 2017 at 02:52:57PM -0500, David Lechner wrote:
> This fixes the TODO to parse strings and convert them to enum values
> when writing to a power_supply class property sysfs attribute.
> 
> There is at least one driver that has a writable enum property that
> previously could only be written as an integer, so a fallback to writing
> enums as integers instead of strings is provided so we don't break existing
> userspace programs.
> 
> Signed-off-by: David Lechner <david@lechnology.com>
>
> ---
>  drivers/power/supply/power_supply_sysfs.c | 124 ++++++++++++++++++++----------
>  1 file changed, 85 insertions(+), 39 deletions(-)

drivers/power/supply/power_supply_sysfs.c: In function ‘power_supply_store_property’:
drivers/power/supply/power_supply_sysfs.c:138:9: error: implicit declaration of function ‘sysfs_match_string’ [-Werror=implicit-function-declaration]

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-04-11 16:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-03 19:52 [PATCH] power: supply: sysfs: parse string as enum when writing property David Lechner
2017-04-11 16:12 ` Sebastian Reichel [this message]
2017-04-11 16:38   ` David Lechner
2017-04-12 14:41     ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170411161222.t23gsn4pvxofhnrh@earth \
    --to=sre@kernel.org \
    --cc=david@lechnology.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox