Re: [PATCH v5 1/2] power: supply: bq24190_charger: Use new extcon_register_notifier_all()

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2091 bytes --]

Hi,

On Thu, Apr 13, 2017 at 02:04:11PM +0200, Hans de Goede wrote:
> When I submitted the extcon handling I had a patch pending for the
> extcon sub-system for extcon_register_notifier to take -1 as cable id
> for listening for all type cable events on an extcon with a single
> notifier.
> 
> In the end it was decided to instead add a new
> extcon_register_notifier_all function for this, switch to using this.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Acked-by: Liam Breck <kernel@networkimprov.net>

With extcon_register_notifier_all() being new and not available
in my tree I can't simply queue this patch. Also it can't simply
go through the extcon subsystem, since it depends on changes in
the power-supply subsystem and results in non-trivial merge conflict.
I see three merge solutions:

 1. Defer to 4.13 (since we are already quite near the merge window)
 2. I need a immutable branch with extcon_register_notifier_all()
    from the extcon subsystem
 3. It may count as Fix and could be queued during the 4.12-rc
    phase based von 4.12-rc1

-- Sebastian

> ---
> Changes in v4:
> -This is a new patch in v4 of this patch-set
> Changes in v5;
> -Add Liam's Acked-by
> ---
>  drivers/power/supply/bq24190_charger.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> index 7c893c0..bd9e5c3 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -1502,8 +1502,8 @@ static int bq24190_probe(struct i2c_client *client,
>  	if (bdi->extcon) {
>  		INIT_DELAYED_WORK(&bdi->extcon_work, bq24190_extcon_work);
>  		bdi->extcon_nb.notifier_call = bq24190_extcon_event;
> -		ret = devm_extcon_register_notifier(dev, bdi->extcon, -1,
> -						    &bdi->extcon_nb);
> +		ret = devm_extcon_register_notifier_all(dev, bdi->extcon,
> +							&bdi->extcon_nb);
>  		if (ret) {
>  			dev_err(dev, "Can't register extcon\n");
>  			goto out_sysfs;
> -- 
> 2.9.3
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]