Re: [PATCH 06/13] power: max17042_battery: Add support for the STATUS property

[Krzysztof Kozlowski <krzk@kernel.org>]

On Fri, Apr 14, 2017 at 02:59:12PM +0200, Hans de Goede wrote:
> Userspace prefers the driver having a status property over having to guess
> itself. Specifically this will properly make the GNOME3 UI (and likely
> others) properly show discharging / charging / full status, instead
> of always showing discharging as status.
> 
> Note that in the case there is no charger driver supplying the max17042,
> then a status of unknown will get returned. At least upower treats
> this the same as not having a status attribute, so in this case nothing
> changes from a userspace pov.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/power/supply/max17042_battery.c | 49 +++++++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
> 
> diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
> index f8a0384..1ea8368 100644
> --- a/drivers/power/supply/max17042_battery.c
> +++ b/drivers/power/supply/max17042_battery.c
> @@ -65,6 +65,9 @@
>  
>  #define MAX17042_VMAX_TOLERANCE		50 /* 50 mV */
>  
> +/* Consider RepCap which is less then 10 units below FullCAP full */
> +#define MAX17042_FULL_THRESHOLD		10

How about grouping all of defaults and configuration values in one
place? Some of them are already in
include/linux/power/max17042_battery.h.

Best regards,
Krzysztof