From: Eduardo Valentin <edubezval@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Javi Merino <javi.merino@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
linaro-kernel@lists.linaro.org,
Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core
Date: Mon, 17 Apr 2017 10:34:34 -0700 [thread overview]
Message-ID: <20170417173431.GA10447@localhost.localdomain> (raw)
In-Reply-To: <cover.1492408342.git.viresh.kumar@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1752 bytes --]
Hey,
On Mon, Apr 17, 2017 at 11:31:45AM +0530, Viresh Kumar wrote:
> Hi Guys,
>
> The cpu_cooling driver is designed to use CPU frequency scaling to avoid
> high thermal states for a platform. But it wasn't glued really well with
> cpufreq core.
>
> This series tries to improve interactions between cpufreq core and
> cpu_cooling driver and does some fixes/cleanups to the cpu_cooling
> driver.
Can you please be more specific of what exactly is not gluing
properly/really well? I like refactoring, as long as well justified.
Do you see anything broken currently?
Or is it more of a optimization in terms of data structures and how
things are computed?
>
> I have tested it on ARM 32 (exynos) and 64 bit (hikey) boards and have
> pushed them for 0-day build bot and kernel CI testing as well. We should
> know if something is broken with these.
Nice. What governors did you try? Have you checked "power_allocator" by
any chance?
>
> @Javi: It would be good if you can give them a test, specially because
> of your work on the "power" specific bits in the driver.
>
@Javi, are you still around? This needs to be validated in terms of how
the cdev states and power models are computed. Just to make sure we are
in one piece. Copying the ARM folks too, Punit?.
I will see if I have some time later this week to check if IPA is in one
piece after this series.
> Pushed here as well:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git thermal/cooling
>
> V1->V2:
> - Name cpufreq cooling dev as cpufreq_cdev everywhere (Eduardo).
That was just very minor stuff. Overall, I do not see major issues, but
I want to spend some more time on this before acking on my side.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-04-17 17:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 6:01 [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 01/17] thermal: cpu_cooling: Avoid accessing potentially freed structures Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 02/17] thermal: cpu_cooling: rearrange globals Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 03/17] thermal: cpu_cooling: Name cpufreq cooling devices as cpufreq_cdev Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 04/17] thermal: cpu_cooling: replace cool_dev with cdev Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 05/17] thermal: cpu_cooling: remove cpufreq_cooling_get_level() Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 06/17] thermal: cpu_cooling: get rid of a variable in cpufreq_set_cur_state() Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 07/17] thermal: cpu_cooling: use cpufreq_policy to register cooling device Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 08/17] cpufreq: create cpufreq_table_count_valid_entries() Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 09/17] thermal: cpu_cooling: store cpufreq policy Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 10/17] thermal: cpu_cooling: OPPs are registered for all CPUs Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 11/17] thermal: cpu_cooling: get rid of 'allowed_cpus' Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 12/17] thermal: cpu_cooling: merge frequency and power tables Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 13/17] thermal: cpu_cooling: create structure for idle time stats Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 14/17] thermal: cpu_cooling: get_level() can't fail Viresh Kumar
2017-04-17 6:02 ` [PATCH V2 15/17] thermal: cpu_cooling: don't store cpu_dev in cpufreq_cdev Viresh Kumar
2017-04-17 6:02 ` [PATCH V2 16/17] thermal: cpu_cooling: 'freq' can't be zero in cpufreq_state2power() Viresh Kumar
2017-04-17 6:02 ` [PATCH V2 17/17] thermal: cpu_cooling: Rearrange struct cpufreq_cooling_device Viresh Kumar
2017-04-17 17:34 ` Eduardo Valentin [this message]
2017-04-17 17:51 ` [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core Eduardo Valentin
2017-04-18 7:23 ` Lukasz Luba
2017-04-18 10:38 ` Viresh Kumar
2017-04-18 14:40 ` Lukasz Luba
2017-04-18 14:51 ` [PATCH] thermal: fix cpu cooling initialization Lukasz Luba
2017-04-19 5:22 ` [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core Viresh Kumar
2017-04-24 10:43 ` Lukasz Luba
2017-04-24 10:44 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170417173431.GA10447@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=amit.kachhap@gmail.com \
--cc=javi.merino@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).