From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: [patch V2 10/10] timer: Always queue timers on the local CPU Date: Tue, 18 Apr 2017 13:11:12 +0200 Message-ID: <20170418111401.200746048@linutronix.de> References: <20170418111102.490432548@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Return-path: Received: from Galois.linutronix.de ([146.0.238.70]:52336 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197AbdDRQqW (ORCPT ); Tue, 18 Apr 2017 12:46:22 -0400 Content-Disposition: inline; filename=timer_Place_timers_on_the_local_CPU.patch Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: LKML Cc: Peter Zijlstra , John Stultz , Eric Dumazet , Anna-Maria Gleixner , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Arjan van de Ven , "Paul E. McKenney" , Frederic Weisbecker , Rik van Riel , Richard Cochran The timer pull model is in place so we can remove the heuristics which try to guess the best target CPU at enqueue/modification time. All non pinned timers are queued on the local cpu in the seperate storage and eventually pulled at expiry time to a remote cpu. Signed-off-by: Richard Cochran Signed-off-by: Anna-Maria Gleixner Signed-off-by: Thomas Gleixner --- kernel/time/timer.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -857,18 +857,6 @@ static inline struct timer_base *get_tim } #ifdef CONFIG_NO_HZ_COMMON -static inline struct timer_base * -get_target_base(struct timer_base *base, unsigned tflags) -{ -#ifdef CONFIG_SMP - if ((tflags & TIMER_PINNED) || !base->migration_enabled) - return get_timer_this_cpu_base(tflags); - return get_timer_cpu_base(tflags, get_nohz_timer_target()); -#else - return get_timer_this_cpu_base(tflags); -#endif -} - static inline void forward_timer_base(struct timer_base *base) { unsigned long jnow = READ_ONCE(jiffies); @@ -890,12 +878,6 @@ static inline void forward_timer_base(st base->clk = base->next_expiry; } #else -static inline struct timer_base * -get_target_base(struct timer_base *base, unsigned tflags) -{ - return get_timer_this_cpu_base(tflags); -} - static inline void forward_timer_base(struct timer_base *base) { } #endif @@ -985,7 +967,7 @@ static inline int if (!ret && pending_only) goto out_unlock; - new_base = get_target_base(base, timer->flags); + new_base = get_timer_this_cpu_base(timer->flags); if (base != new_base) { /*