From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Liam Breck <liam@networkimprov.net>
Cc: linux-pm@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Hans de Goede <hdegoede@redhat.com>,
Liam Breck <kernel@networkimprov.net>
Subject: Re: [PATCH v1 1/1] power: bq24190_charger: Deprecate battery class and replicate its features in charger
Date: Mon, 1 May 2017 13:29:22 +0200 [thread overview]
Message-ID: <20170501112922.zmpb4v3v5kawu223@earth> (raw)
In-Reply-To: <20170416230626.30022-1-liam@networkimprov.net>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
Hi,
On Sun, Apr 16, 2017 at 04:06:26PM -0700, Liam Breck wrote:
> From: Liam Breck <kernel@networkimprov.net>
>
> The driver was registering two classes, bq24190-battery & -charger.
> Because the power supply framework cannot surface features from multiple
> drivers in a single class, a fuel gauge driver would create a third class,
> which some power management utilities cannot see.
>
> Deprecate the -battery class for future removal and replicate its features
> in -charger. Set /sys/class...-charger/online = pg_stat && !batfet_disable.
> If device_property "omit-battery-class" is set, don't register -battery.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Liam Breck <kernel@networkimprov.net>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-05-01 11:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 23:06 [PATCH v1 1/1] power: bq24190_charger: Deprecate battery class and replicate its features in charger Liam Breck
2017-04-18 8:05 ` Hans de Goede
2017-04-18 9:42 ` Liam Breck
2017-04-18 10:05 ` Hans de Goede
2017-04-18 10:27 ` Liam Breck
2017-04-18 11:49 ` Hans de Goede
2017-05-01 11:29 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501112922.zmpb4v3v5kawu223@earth \
--to=sebastian.reichel@collabora.co.uk \
--cc=hdegoede@redhat.com \
--cc=kernel@networkimprov.net \
--cc=liam@networkimprov.net \
--cc=linux-pm@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox